Skip to content

feat(Term): fingerprint CSS asset - #1222

Merged
ArgoZhang merged 3 commits into
masterfrom
dev-Term
Oct 22, 2026
Merged

ArgoZhang merged 3 commits into
masterfrom
dev-Term

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Link issues

fixes #1221

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Load the Term component stylesheet through a version-aware asset URL.

New Features:

  • Add fingerprint-aware loading for the Term component’s xterm CSS asset.

Enhancements:

  • Support resolving the stylesheet URL through the asset manifest on .NET 9 and newer while retaining compatibility with earlier targets.

ArgoZhang and others added 3 commits October 18, 2026 14:29
@sourcery-ai

sourcery-ai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR makes the Term component load xterm.css through a framework-aware URL: .NET 9 and later use the generated asset mapping for fingerprinted files, while earlier targets preserve the existing static path, with the resolved URL passed from Blazor to JavaScript.

Sequence diagram for fingerprinted Term CSS loading

sequenceDiagram
    participant Blazor as Term Blazor component
    participant JS as Term JavaScript module
    participant Assets as .NET 9 asset mapping
    participant Browser as Browser

    Blazor->>Assets: Resolve Assets[StylePath]
    Assets-->>Blazor: Return fingerprinted CSS URL
    Blazor->>JS: init(id, invoke, options, styleUrl)
    JS->>Browser: addLink(styleUrl)
    Browser-->>JS: Load xterm.css
Loading

File-Level Changes

Change Details Files
Pass a runtime-resolved CSS asset URL into the Term JavaScript initializer to support fingerprinted static assets.
  • Define the xterm CSS asset path in the component.
  • Resolve the path through the .NET 9 asset manifest when available, with the legacy path retained for earlier target frameworks.
  • Extend JS initialization to load the supplied stylesheet URL instead of a hard-coded path.
src/components/BootstrapBlazor.Term/Components/Term.razor.cs
src/components/BootstrapBlazor.Term/Components/Term.razor.js
Update project configuration to support the asset fingerprinting integration.
  • Add the required project configuration for the fingerprinted CSS asset.
src/components/BootstrapBlazor.Term/BootstrapBlazor.Term.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#1221 Use a fingerprinted URL for the Term component's CSS asset so browsers can cache the asset reliably. ✅

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added the enhancement New feature or request label Oct 22, 2026
@bb-auto bb-auto Bot added this to the v10.0.0 milestone Oct 22, 2026

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang
ArgoZhang merged commit cb3b98c into master Oct 22, 2026
3 checks passed
@ArgoZhang
ArgoZhang deleted the dev-Term branch October 22, 2026 02:58

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Term): fingerprint CSS asset

1 participant