Repository navigation
feat(Player): fingerprint CSS asset - #1218
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe player now injects its CSS using a framework-aware asset URL: .NET 9+ resolves the path through the generated static asset manifest for fingerprinting, while older targets retain the existing path, with the URL passed from the component to the JavaScript initializer. Sequence diagram for framework-aware Player CSS loadingsequenceDiagram
participant Player as Player component
participant JS as Player JavaScript
participant Assets as .NET 9 asset manifest
participant Browser as Browser
Player->>Player: InvokeInitAsync()
alt NET9_0_OR_GREATER
Player->>Assets: Resolve Assets[StylePath]
Assets-->>Player: Fingerprinted styleUrl
else Older target
Player-->>Player: Use StylePath
end
Player->>JS: init(id, invoke, method, options, styleUrl)
JS->>Browser: addLink(styleUrl)
Browser-->>JS: Load plyr.css
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #1217
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Support fingerprinted Player stylesheet assets across supported target frameworks.
Bug Fixes:
Enhancements: