Skip to content

feat(OfficeViewer): fingerprint CSS asset - #1216

Merged
ArgoZhang merged 3 commits into
masterfrom
dev-OfficeViewer
Oct 21, 2026
Merged

ArgoZhang merged 3 commits into
masterfrom
dev-OfficeViewer

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Link issues

fixes #1215

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Support fingerprinted CSS assets in OfficeViewer initialization.

Bug Fixes:

  • Ensure the OfficeViewer CSS asset URL is resolved correctly when assets are fingerprinted on supported .NET versions.

Enhancements:

  • Centralize OfficeViewer stylesheet URL handling across server-side initialization and JavaScript asset loading.

Build:

  • Add the OfficeViewer stylesheet to the project asset configuration for fingerprinted asset resolution.

ArgoZhang and others added 2 commits October 18, 2026 14:29
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sourcery-ai

sourcery-ai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

OfficeViewer now resolves its CSS through the .NET 9 asset manifest for fingerprinting while retaining the existing static path on earlier target frameworks, then passes that URL to JavaScript for stylesheet loading.

Sequence diagram for fingerprinted OfficeViewer CSS loading

sequenceDiagram
    participant OfficeViewer
    participant AssetManifest
    participant JavaScript
    participant Browser

    OfficeViewer->>OfficeViewer: OnAfterRenderAsync
    alt NET9_0_OR_GREATER
        OfficeViewer->>AssetManifest: Assets[StylePath]
        AssetManifest-->>OfficeViewer: fingerprinted StyleUrl
    else Earlier target frameworks
        OfficeViewer->>OfficeViewer: StylePath
    end
    OfficeViewer->>JavaScript: init(id, invoke, options, StyleUrl)
    JavaScript->>Browser: addLink(styleUrl)
    Browser-->>JavaScript: stylesheet loaded
Loading

File-Level Changes

Change Details Files
Pass a framework-aware, fingerprinted CSS asset URL into the OfficeViewer JavaScript initializer.
  • Define the stylesheet path centrally and resolve it through the .NET 9 asset manifest when available.
  • Forward the resolved URL during JavaScript module initialization.
  • Update JavaScript initialization to load the supplied stylesheet URL instead of constructing a fixed relative path.
src/components/BootstrapBlazor.OfficeViewer/OfficeViewer.razor.cs
src/components/BootstrapBlazor.OfficeViewer/OfficeViewer.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#1215 Use a fingerprinted URL when loading the OfficeViewer CSS asset. ✅

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added the enhancement New feature or request label Oct 21, 2026
@bb-auto bb-auto Bot added this to the v10.0.0 milestone Oct 21, 2026
bb-auto[bot]
bb-auto Bot previously approved these changes Oct 21, 2026

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang
ArgoZhang merged commit c0facd7 into master Oct 21, 2026
3 checks passed
@ArgoZhang
ArgoZhang deleted the dev-OfficeViewer branch October 21, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(OfficeViewer): fingerprint CSS asset

1 participant