[benma]

Similar to BitBoxSwiss/bitbox02-api-go#141

[NickeZ]

I'm going to need some instructions on how to test this PR :)

[benma]

I'm going to need some instructions on how to test this PR :)

Hmm you didn't test the same PR in Go 😄 BitBoxSwiss/bitbox02-api-go#141

There is a simulator test and unit tests here, isn't that sufficient? I could try to provide a new file in examples/, but it's not so great to keep adding more examples there 🤔

[benma]

@NickeZ added an example anyway, run make example-btc-sign-op-return, see added commit.

[NickeZ]

@NickeZ added an example anyway, run make example-btc-sign-op-return, see added commit.

$ make example-btc-sign-op-return
cargo run --example btc_sign_op_return --features=usb,tokio/rt,tokio/macros
   Compiling bitcoin-internals v0.3.0
   Compiling secp256k1-sys v0.10.0
   Compiling serde v1.0.203
   Compiling bitcoin_hashes v0.14.0
   Compiling getrandom v0.2.15
   Compiling bitcoin v0.32.2
   Compiling hex v0.4.3
   Compiling rand_core v0.6.4
   Compiling x25519-dalek v2.0.1
   Compiling noise-rust-crypto v0.6.2
   Compiling base58ck v0.1.0
   Compiling bitcoin-units v0.1.2
   Compiling serde_json v1.0.120
   Compiling serde_urlencoded v0.7.1
   Compiling reqwest v0.12.5
   Compiling secp256k1 v0.29.0
   Compiling miniscript v12.0.0
   Compiling bitbox-api v0.11.0 (/Users/niklasdusenlund/projects/shift/bitbox-api-rs)
error[E0599]: no method named `finalize_mut` found for struct `bitcoin::Psbt` in the current scope
   --> examples/btc_sign_op_return.rs:165:10
    |
165 |     psbt.finalize_mut(&secp).unwrap();
    |          ^^^^^^^^^^^^ method not found in `bitcoin::Psbt`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `bitbox-api` (example "btc_sign_op_return") due to 1 previous error
make: *** [example-btc-sign-op-return] Error 101

[benma]

@NickeZ added an example anyway, run make example-btc-sign-op-return, see added commit.

$ make example-btc-sign-op-return
cargo run --example btc_sign_op_return --features=usb,tokio/rt,tokio/macros
   Compiling bitcoin-internals v0.3.0
   Compiling secp256k1-sys v0.10.0
   Compiling serde v1.0.203
   Compiling bitcoin_hashes v0.14.0
   Compiling getrandom v0.2.15
   Compiling bitcoin v0.32.2
   Compiling hex v0.4.3
   Compiling rand_core v0.6.4
   Compiling x25519-dalek v2.0.1
   Compiling noise-rust-crypto v0.6.2
   Compiling base58ck v0.1.0
   Compiling bitcoin-units v0.1.2
   Compiling serde_json v1.0.120
   Compiling serde_urlencoded v0.7.1
   Compiling reqwest v0.12.5
   Compiling secp256k1 v0.29.0
   Compiling miniscript v12.0.0
   Compiling bitbox-api v0.11.0 (/Users/niklasdusenlund/projects/shift/bitbox-api-rs)
error[E0599]: no method named `finalize_mut` found for struct `bitcoin::Psbt` in the current scope
   --> examples/btc_sign_op_return.rs:165:10
    |
165 |     psbt.finalize_mut(&secp).unwrap();
    |          ^^^^^^^^^^^^ method not found in `bitcoin::Psbt`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `bitbox-api` (example "btc_sign_op_return") due to 1 previous error
make: *** [example-btc-sign-op-return] Error 101

Oops, forgot to delete these lines. Removed now

[NickeZ]

tACK