Skip to content

fix(bedrock): guard empty choices in mistral get_outputText #34610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfedoryshchev wants to merge 1 commit into
base: litellm_internal_staging
Choose a base branch
from
+13 −1
Open

fix(bedrock): guard empty choices in mistral get_outputText #34610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion litellm/llms/bedrock/chat/invoke_transformations/amazon_mistral_transformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def get_outputText(completion_response: dict, model_response: "ModelResponse") -
A string with the response of the LLM

"""
if "choices" in completion_response:
if "choices" in completion_response and len(completion_response["choices"]) > 0:
outputText = completion_response["choices"][0]["message"]["content"]
model_response.choices[0].finish_reason = completion_response["choices"][0]["finish_reason"]
elif "outputs" in completion_response:
Expand Down
12 changes: 12 additions & 0 deletions tests/test_litellm/llms/bedrock/chat/test_mistral_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import pytest

from litellm.llms.bedrock.chat.invoke_transformations.amazon_mistral_transformation import (
AmazonMistralConfig,
)
from litellm.llms.bedrock.common_utils import BedrockError
from litellm.types.utils import ModelResponse


Expand Down Expand Up @@ -30,3 +33,12 @@ def test_mistral_get_outputText():

assert outputText == "Hi!"
assert model_response.choices[0].finish_reason == "finish"


def test_mistral_get_outputText_empty_choices():
model_response = ModelResponse()

with pytest.raises(BedrockError):
AmazonMistralConfig.get_outputText(
completion_response={"choices": []}, model_response=model_response
)
Loading