build: authorize pydantic-settings in the license check#34601
Open
mubashir1osmani wants to merge 1 commit into
Open
build: authorize pydantic-settings in the license check#34601mubashir1osmani wants to merge 1 commit into
mubashir1osmani wants to merge 1 commit into
Conversation
The license job fails on staging with "pydantic-settings (2.14.1) - Unknown license". The package is a direct dependency (pyproject.toml constrains >=2.14.1,<3.0) and is genuinely MIT: PyPI reports license_expression "MIT" and the classifier "License :: OSI Approved :: MIT License". Its legacy `license` metadata field is empty, which is the field liccheck reads, so it lands in the unknown bucket. Add it to [Authorized Packages] with the verified license and a link, following the convention the rest of the file uses.
Contributor
Greptile SummaryAuthorizes Confidence Score: 5/5The PR appears safe to merge because the new authorization entry follows the existing configuration format and covers the repository's declared dependency range. The commented authorization entry is parsed successfully and causes the license checker to recognize
|
| Filename | Overview |
|---|---|
| tests/code_coverage_tests/liccheck.ini | Adds pydantic-settings>=2.14.1 to the authorized package list, allowing the license job to accept the dependency as MIT-licensed. |
Reviews (1): Last reviewed commit: "build: authorize pydantic-settings in th..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
The license job fails with
pydantic-settings (2.14.1) - Unknown license. This authorizes it with a verified license.Why it is unknown
pydantic-settingsis a direct dependency (pyproject.tomlconstrains>=2.14.1,<3.0, added 2026-07-16 in #33222), and it is genuinely MIT. PyPI reports both a PEP 639license_expression: "MIT"and the classifierLicense :: OSI Approved :: MIT License:The legacy
licensefield is empty, and that is the field liccheck reads, so the package lands in the unknown bucket despite declaring MIT two other ways. Packages that publish their license only via PEP 639 will keep hitting this.Changes
One entry in
[Authorized Packages]following the convention the rest of the file uses (pin, license, link):Verified the config still parses and the entry is readable under
[Authorized Packages].Type
🚄 Infrastructure