Skip to content

build: authorize pydantic-settings in the license check#34601

Open
mubashir1osmani wants to merge 1 commit into
litellm_internal_stagingfrom
litellm_liccheck_pydantic_settings
Open

build: authorize pydantic-settings in the license check#34601
mubashir1osmani wants to merge 1 commit into
litellm_internal_stagingfrom
litellm_liccheck_pydantic_settings

Conversation

@mubashir1osmani

Copy link
Copy Markdown
Collaborator

TLDR

The license job fails with pydantic-settings (2.14.1) - Unknown license. This authorizes it with a verified license.

Why it is unknown

pydantic-settings is a direct dependency (pyproject.toml constrains >=2.14.1,<3.0, added 2026-07-16 in #33222), and it is genuinely MIT. PyPI reports both a PEP 639 license_expression: "MIT" and the classifier License :: OSI Approved :: MIT License:

$ curl -s https://pypi.org/pypi/pydantic-settings/2.14.1/json | jq '.info | {license, license_expression, cls: [.classifiers[] | select(contains("License"))]}'
{
  "license": null,
  "license_expression": "MIT",
  "cls": ["License :: OSI Approved :: MIT License"]
}

The legacy license field is empty, and that is the field liccheck reads, so the package lands in the unknown bucket despite declaring MIT two other ways. Packages that publish their license only via PEP 639 will keep hitting this.

Changes

One entry in [Authorized Packages] following the convention the rest of the file uses (pin, license, link):

pydantic-settings: >=2.14.1 # MIT License - https://github.com/pydantic/pydantic-settings/blob/main/LICENSE

Verified the config still parses and the entry is readable under [Authorized Packages].

Type

🚄 Infrastructure

The license job fails on staging with "pydantic-settings (2.14.1) - Unknown
license". The package is a direct dependency (pyproject.toml constrains
>=2.14.1,<3.0) and is genuinely MIT: PyPI reports license_expression "MIT" and
the classifier "License :: OSI Approved :: MIT License". Its legacy `license`
metadata field is empty, which is the field liccheck reads, so it lands in the
unknown bucket.

Add it to [Authorized Packages] with the verified license and a link, following
the convention the rest of the file uses.
@greptile-apps

greptile-apps Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Authorizes pydantic-settings in the license-check configuration using its existing dependency lower bound and verified MIT license reference.

Confidence Score: 5/5

The PR appears safe to merge because the new authorization entry follows the existing configuration format and covers the repository's declared dependency range.

The commented authorization entry is parsed successfully and causes the license checker to recognize pydantic-settings, while its lower bound matches the dependency declared in pyproject.toml.

Important Files Changed

Filename Overview
tests/code_coverage_tests/liccheck.ini Adds pydantic-settings>=2.14.1 to the authorized package list, allowing the license job to accept the dependency as MIT-licensed.

Reviews (1): Last reviewed commit: "build: authorize pydantic-settings in th..." | Re-trigger Greptile

@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant