-
Notifications
You must be signed in to change notification settings - Fork 0
AP-515: add 4.9.6 image for cross-platform testing #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7ed9ecd
AP-515: add 4.9.6 image for cross-platform testing
anarchivist 59bf731
simplify test runner given the reliance on supervisord
anarchivist e953159
allow supervisord to drop privileges to APP_USER
anarchivist 7b8024e
drop privileges to APP_USER earlier to ensure stdout/stderr have corr…
anarchivist 5e5c7b8
send supervisord process logs to container's stdout
anarchivist 139e4cf
misc cleanup
anarchivist 7bcaad7
address PR feedback
anarchivist e939418
fix whitespace and supervisord.conf template comment
anarchivist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to duplicate the logs to stdout (i.e., they're sent twice for the
supervisord's process logs):Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker recommends a few modifications to this, most notably setting supervisord's logfile to /dev/null:
I'm not sure why they write program logs to
/dev/fd/1versus the more familar/dev/stdout, when as far as I can tell they're equivalent. From this image:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 7bcaad7.
nodaemon=trueis unnecessary as the Wowza image entrypoint that our entrypoint scriptexecs into callssupervisord -n.