Fix "Handle is not initialized" for Unity 2021.2.x games#232
Conversation
|
i wonder if #216 also fixes this issue. it totally elides |
|
I tried using the improved-gc branch testwise - used Common.dll, HarmonySupport.dll and Runtime.dll from that one (If I need other ones, please yell at me) and currently the game crashed. The log is attached. Ultimate error is: I didn't have much time to look into this now, I will try to see using your branch if I can get it to work. My best guess is that Thank you for looking. |
ManlyMarco
left a comment
ManlyMarco
left a comment
There was a problem hiding this comment.
It's a hack but it seems to be working well, merging for v1.5.1.
This code will be replaced in v2.0 with a proper fix.
When the mono object is a System.Action object it seems GetGcHandlePtrFromIl2CppObject(pointer) returns a null pointer for the Garbage Collector Handle (or well IntPtr.Zero). This causes GCHandle.FromIntPtr(gcHandle) to throw an excepction. One solution after a lot of back and forth was to essentially check if the object class is a Delegate type class (which includes System.Action) and if so, get the garbage collector handle on the mTarget of the delegate object. This way in my testing the code will not interfere with other Unity versions - yet it allows to hook onto my test game - which happens to be a 2021.2.x game compiled with IL2CPP. In other Unity versions if (gcHandle == IntPtr.Zero) should be false so I doubt this would interfere in any way (it worked fine in other tested games for me). ---- It's a hack but it seems to be working well, merging for v1.5.1. This code will be replaced in v2.0 with a proper fix. (cherry picked from commit f39ea5a)
When the mono object is a System.Action object it seems GetGcHandlePtrFromIl2CppObject(pointer) returns a null pointer for the Garbage Collector Handle (or well IntPtr.Zero). This causes GCHandle.FromIntPtr(gcHandle) to throw an excepction. One solution after a lot of back and forth was to essentially check if the object class is a Delegate type class (which includes System.Action) and if so, get the garbage collector handle on the mTarget of the delegate object. This way in my testing the code will not interfere with other Unity versions - yet it allows to hook onto my test game - which happens to be a 2021.2.x game compiled with IL2CPP. In other Unity versions if (gcHandle == IntPtr.Zero) should be false so I doubt this would interfere in any way (it worked fine in other tested games for me). ---- It's a hack but it seems to be working well, merging for v1.5.1. This code will be replaced in v2.0 with a proper fix.
4 participants
This is a fix proposal for #210 - I was trying to work with Neptunia Sisters Vs Sisters which is affected by the same issue the user reported there.
When the mono object is a System.Action object it seems
GetGcHandlePtrFromIl2CppObject(pointer)returns a null pointer for the Garbage Collector Handle (or well IntPtr.Zero). This causesGCHandle.FromIntPtr(gcHandle)to throw an excepction.One solution after a lot of back and forth was to essentially check if the object class is a Delegate type class (which includes System.Action) and if so, get the garbage collector handle on the mTarget of the delegate object. This way in my testing the code will not interfere with other Unity versions - yet it allows to hook onto my test game - which happens to be a 2021.2.x game compiled with IL2CPP.
In other Unity versions
if (gcHandle == IntPtr.Zero)should be false so I doubt this would interfere in any way (it worked fine in other tested games for me).