Skip to content

Switch to Prism#3212

Merged
hwangsihu merged 2 commits intomasterfrom
prism
Apr 28, 2026
Merged

Switch to Prism#3212
hwangsihu merged 2 commits intomasterfrom
prism

Conversation

@hwangsihu
Copy link
Copy Markdown
Contributor

@hwangsihu hwangsihu commented Apr 12, 2026

Fixes #3061

@Nardol
Copy link
Copy Markdown
Contributor

Nardol commented Apr 13, 2026

Why disabling it on Ubuntu 22?
Unfortunately, on Debian Bookworm which is still a maintained version, the only TeamTalk version we can use is the Ubuntu 22 one.
And it is perfectly possible to use Orca master or compiled from the Git repository, so a version which could benefit from Prism.
I have not read Prism cannot be built on Ubuntu 22 but might have missed it.

@hwangsihu
Copy link
Copy Markdown
Contributor Author

It seems the Ubuntu 22 compiler doesn't support that. How did you build it?

@Nardol
Copy link
Copy Markdown
Contributor

Nardol commented Apr 13, 2026

I have not tested it yet. I have only read the documentation, and it does not mention any compatibility issues. That is why I asked you to explain your decision to disable it for Ubuntu 22.
Thanks.

@hwangsihu
Copy link
Copy Markdown
Contributor Author

Since Ubuntu 22 uses a very old G++ compiler, some features required by Prism cannot be used.

Ah, come to think of it, I saw the whole TeamTalk compiled on the latest CLANG the other day, so maybe it is possible to do that.

@hwangsihu
Copy link
Copy Markdown
Contributor Author

Hmm, it doesn't seem to be working. For now, I need to resolve other errors first, so I will think of a solution once that is finished. However, I might have to give up.

@hwangsihu hwangsihu force-pushed the prism branch 13 times, most recently from 876049a to 1a68510 Compare April 17, 2026 11:08
@hwangsihu hwangsihu marked this pull request as ready for review April 18, 2026 07:41
@hwangsihu hwangsihu requested review from a team, CoBC and bear101 as code owners April 18, 2026 07:41
Comment thread Client/Prism/CMakeLists.txt Outdated
Copy link
Copy Markdown
Contributor

@bear101 bear101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested on macOS and everything looks fine. @CoBC do you have time to test on Windows and Linux?

@jeremyp3
Copy link
Copy Markdown
Contributor

Hello,

I just tested the Prism branch on Linux.

In principle, it works, but I'm encountering a few bugs:

  • When you select Prism and its options in the preferences and click OK, TeamTalk freezes until you restart Orca.
  • With Prism still enabled, when you connect to a server or join a channel, if Orca is enabled, there is a delay. If Orca is not enabled, everything happens instantly.

@hwangsihu
Copy link
Copy Markdown
Contributor Author

Ah, I encountered that problem as well. I'll fix it in a bit.

@hwangsihu
Copy link
Copy Markdown
Contributor Author

It seems to work mostly correctly on Windows, but since I don't have zdsr, I'm not sure if zdsrapi.dll loads properly. Could someone with zdsr test this for me?

@CoBC
Copy link
Copy Markdown
Contributor

CoBC commented Apr 25, 2026

Tested on Windows and it works as expected

@hwangsihu hwangsihu force-pushed the prism branch 2 times, most recently from 3d67987 to 1979c9c Compare April 26, 2026 06:45
@hwangsihu
Copy link
Copy Markdown
Contributor Author

@jeremyp3, Can you test again?

Copy link
Copy Markdown
Contributor

@bear101 bear101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits.

@jeremyp3
Copy link
Copy Markdown
Contributor

@hwangsihu
can confirm that the previous bug on Linux has been fixed.

Thanks !

@hwangsihu
Copy link
Copy Markdown
Contributor Author

Since the Ubuntu 22 disable commit might be reverted later, I think it would be better to rebase.

@hwangsihu hwangsihu merged commit da149c2 into master Apr 28, 2026
15 of 17 checks passed
@hwangsihu hwangsihu deleted the prism branch April 28, 2026 23:11
@bear101 bear101 added this to the TeamTalk v5.23 milestone Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can Teamtalk add support for zdsr screen readers?

5 participants