chore: remove UserStatus.UNKNOWN#160
Merged
cbachhuber merged 3 commits intomainfrom Mar 19, 2026
Merged
Conversation
cbachhuber
commented
Mar 19, 2026
Comment on lines
+125
to
+134
| st.markdown( | ||
| """ | ||
| <style> | ||
| div[data-testid="stRadio"] label { | ||
| padding: 6px; | ||
| } | ||
| </style> | ||
| """, | ||
| unsafe_allow_html=True, | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
Without this, the radio buttons look weirdly compact next to the bar chart. And I don't want to reduce the bar chart's height.
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
show_user_status_selection, consider making theindex = status_options.index(current_user_status)more defensive (e.g., defaulting to 0 if the status isn’t in the list) to avoid runtime errors if new statuses are introduced or if state becomes inconsistent. - The global CSS rule targeting
div[data-testid="stRadio"] labelwill affect all radio components in the app; if the padding change is only intended for the user status control, consider scoping the selector more narrowly (e.g., wrapping that specific radio in a container with a dedicated class).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `show_user_status_selection`, consider making the `index = status_options.index(current_user_status)` more defensive (e.g., defaulting to 0 if the status isn’t in the list) to avoid runtime errors if new statuses are introduced or if state becomes inconsistent.
- The global CSS rule targeting `div[data-testid="stRadio"] label` will affect all radio components in the app; if the padding change is only intended for the user status control, consider scoping the selector more narrowly (e.g., wrapping that specific radio in a container with a dedicated class).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 503 498 -5
=========================================
- Hits 503 498 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BayerC
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As agreed in #151. Audience view: