Add ReduceGroundCartesianProduct - #731
Open
eb8680 wants to merge 2 commits into
Open
Conversation
eb8680
force-pushed
the
eb-ground-cartesian-product
branch
from
July 28, 2026 16:07
c5efdf2 to
93a5895
Compare
eb8680
marked this pull request as ready for review
July 29, 2026 00:08
Contributor
Author
|
The slop in the PR description is from disaggregating #724. The code in this PR was largely written and checked by me. |
jfeser
requested changes
Jul 29, 2026
jfeser
left a comment
Contributor
There was a problem hiding this comment.
I pushed some new tests that currently fail. We should either fix those cases or forward. The diagonal stream consumption issue also affects ReduceDistributeCartesianProduct (there it causes a performance problem, not a correctness one).
Replaces a cartesian-product stream with one stream per plate assignment the body actually subscripts. Where the body folds over the plates uniformly, ReduceDistributeCartesianProduct inverts the reduction instead, which is cheaper and leaves the plate fold intact. This rule is the fallback for bodies that admit no per-plate factorization: a chain `X[t], X[t+1]` couples adjacent plate indices, so inversion does not apply. Grounding costs one variable per assignment instead of enumerating the |D|^|P| rows, after which the result is an ordinary variable-elimination problem that `Factor` solves. `ReducePartial` gains an `unrolled` filter so grounding can expand only the plate folds it is grounding over. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jfeser
force-pushed
the
eb-ground-cartesian-product
branch
from
July 30, 2026 18:58
7acbe8c to
7be9b05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ReduceGroundCartesianProduct, the fallback rule for a reduction over acartesian-product row stream whose body admits no per-plate factorization.
The rewrite
where
aranges over the plate assignments the body actually subscripts._GroundRowis aMappingthat stands in for the row variable. Unrolling thebody's plate folds hands it concrete keys, and it answers each with a variable
minted on first sight (the same variable for a repeated key, which is what ties
the factors of a chain together). A key that is still symbolic never reaches it:
the subscript stays a term until the fold supplying the index is expanded.
_GroundRow.residualreturns whatever plate values no key consumed, which stayin the expression as a smaller cartesian product;
sealed+fvsofreject ahalf-ground result, in which case the rule declines.
When this applies vs.
ReduceDistributeCartesianProductWhere the body folds over the plates uniformly,
ReduceDistributeCartesianProductinverts the reduction instead — cheaper, and it leaves the plate fold intact.
Grounding is for bodies where inversion does not apply, e.g. a chain
X[t], X[t+1]couples adjacent plate indices. Grounding costs one variable perassignment (
|P|variables overD) instead of enumerating the|D|^|P|rows,after which what is left is an ordinary variable-elimination problem that
Factorsolves.ReduceGroundCartesianProduct()is registered inNormalizeIntpimmediately beforeReduceDistributeCartesianProduct().ReduceDistributeCartesianProductitself is untouched here.ReducePartial.unrolledReducePartialgains an optionalunrolledset of stream variables and skipsany stream not in it. Grounding installs
ReducePartial(plate_vars)so thatexpanding the body expands only the plate folds it is grounding over, and not,
say, the value domains.
Test
tests/test_ops_monoid.py::test_ground_cartesian_product_chainreduces a chainSum_ixs Prod_t phi[t][ixs[t]][ixs[t+1]]and checks the result against theforward algorithm computed in plain Python.
It is written longhand with explicit
defopvariables. In #724 it is writtenas
using the generator-comprehension syntax that lands in a later PR; the body
below is exactly what
desugar_comprehensionproduces for it.Tis 10 rather than the 20 used in #724: normalization is superlinear in thechain length until the separate
evaluateperformance fix lands, and thisbranch is deliberately not stacked on it. At
T = 10the test takes ~6s; atT = 20it takes over an hour.K = 3as in #724.The test does discriminate: unregistering the rule makes normalization a no-op
and the added structural assertion fails immediately. (Without that assertion
the test would still pass at
T = 10, just 11x slower, because evaluationfalls back to enumerating all
K ** Trows — which is why the assertion isthere.)
Prerequisite: #729
This PR is stacked on #729 (
eb-jax-scalar-plus), which fixes_jax_argsineffectful/handlers/jax/monoid.py. That fix is a genuine prerequisite here, nota cosmetic one:
jax.typing.ArrayLikeincludesbool/int/float/complex,so the jax handlers claimed pure-Python scalar arithmetic. Without it the new
test does not merely produce a different type — it raises
TypeError: Cannot unify type <class 'int'> with <class 'jax.Array'>, becausetests/test_ops_monoid.pyimportseffectful.handlers.jax.monoidunconditionally.
This branch's own diff is just
effectful/ops/monoid.pyandtests/test_ops_monoid.py.The
ReduceDisequalityMaskor->is Nonefix that also lives in #724 waschecked and is not needed here: the full suite passes without it.
Testing
tests/test_ops_monoid.py+tests/test_handlers_jax_monoid.py: 531 passed.tests/sweep excludingtests/test_handlers_llm_*.py: 18318 passed,2 skipped, 2078 xfailed — versus 18317/2/2078 on pristine
staging-weighted,the difference being the new test. No regressions.
ruff check,ruff format --diffclean.mypyclean apart from the onepre-existing
effectful/handlers/jax/monoid.pyerror already onstaging-weighted.Split out of #724 for review. Stacked on #729. Independent of the sibling
ReduceDistributeCartesianProductrefactor (#730), also split out of #724.🤖 Generated with Claude Code