Closes #660 - #833
Open
mansur-codes wants to merge 11 commits into
Open
Conversation
…nt, batch_transfer
|
@mansur-codes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@mansur-codes please resolve conflicts |
Contributor
|
@mansur-codes resolve conflicts |
Contributor
Author
|
I will resolve it, i'm on it, its just taking a while |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
timelock_expires_at: Option<u64>toUpgradeProposalto enforce a mandatory delay between quorum and execution. The field isNonewhile a proposal is pre-quorum and snapshotted tonow + TIMELOCK_DELAY_SECS(24 hours) the moment quorum is first reached, via a new_start_upgrade_timelock_if_quoratehelper. Later votes on an already-quorate proposal never reset the value.Also updates the frozen field name/width tests,
upgrade_proposal_fixture, and adds 4 unit tests covering the happy path, idempotency, below-quorum behaviour, and creation state.Type of change
Checklist
pre-commit run --all-fileslocally and it passedBreaking changes?
No.
timelock_expires_atis appended toUpgradeProposaland defaults toNone. Since#[contracttype]encodes struct fields by name, existing persisted proposals decode safely with the new field absent — they will read asNone.Related issues
Closes #660