Feature/731 require sufficient shares - #828
Open
rabsqueen wants to merge 4 commits into
Open
Conversation
|
@rabsqueen Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the core compound_fees functionality for the Yield-Bearing Fee Vaults epic.
The new functionality moves pending protocol fees from the fee contract into the vault pool and adds the compounded tokens to the vault's underlying balance.
This establishes the core mechanism required for protocol fees to be reinvested into the vault rather than remaining idle in the fee contract.
What Changed
Fee Compounding
Implemented the compound_fees function to:
Identify pending fees held by the fee contract.
Pull the available tokens from the fee contract.
Transfer the tokens into the vault pool.
Increase the vault's underlying balance by the compounded amount.
closes #731
closes #722
closes #728
closes #729