Multi-Sig Gated WASM Upgrades: cancel_proposal - #818
Open
deslawson wants to merge 3 commits into
Open
Conversation
|
@deslawson Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@deslawson where are the CI checks? |
Implemented cancel_proposal for the active Proposal governance flow, allowing proposal creators to withdraw their proposal before execution. The function verifies caller identity against the stored creator, removes both the proposal and its timelock entry from state, and emits a prp_cncld event. Six unit tests cover happy path, event emission, timelock cleanup, and all three error conditions (non-creator, already executed, nonexistent). All CI checks pass clean: cargo fmt, cargo clippy, and cargo test (124/124) Closes BCPathway#671
Contributor
|
@deslawson please resolve conflicts |
…ent state. Co-authored-by: Cursor <cursoragent@cursor.com>
…osal merge. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implemented cancel_proposal for the active Proposal governance flow, allowing proposal creators to withdraw their proposal before execution. The function verifies caller identity against the stored creator, removes both the proposal and its timelock entry from state, and emits a prp_cncld event. Six unit tests cover happy path, event emission, timelock cleanup, and all three error conditions (non-creator, already executed, nonexistent). All CI checks pass clean: cargo fmt, cargo clippy, and cargo test (124/124)
Type of change
Checklist
pre-commit run --all-fileslocally and it passedBreaking changes?
Yes. Two breaking ABI changes in bc-forge-admin:
Both are additive changes (new variant, new function) with no reordering or renaming of existing entries.
Related issues
Closes #671