Skip to content
Draft
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d8cac48
Add SN/I certificate support over mTLS Proof-of-Possession (PoP)
Robbie-Microsoft Jul 1, 2026
150a554
Extract FIC Leg 2 (mTLS PoP) into a follow-up PR
Robbie-Microsoft Jul 6, 2026
68d3715
Suppress CredScan finding for self-signed mTLS test certificate
Robbie-Microsoft Jul 6, 2026
66d59db
Fix mTLS PoP socket factory on JDK 8 and address review feedback
Robbie-Microsoft Jul 7, 2026
e6dee5f
Build mTLS PoP socket factory from a live key manager (support non-ex…
Robbie-Microsoft Jul 7, 2026
288df02
Point MtlsPopIT at the SN/I-allow-listed app for mTLS PoP
Robbie-Microsoft Jul 7, 2026
6bf6024
Fail closed on mTLS PoP token_type downgrade
Robbie-Microsoft Jul 8, 2026
f848b54
Remove unused telemetryValue from TokenType
Robbie-Microsoft Jul 8, 2026
3ff929c
Align mTLS PoP with MSAL.NET: sovereign-cloud guard, cache metadata, …
Robbie-Microsoft Jul 8, 2026
3ef7681
Align mTLS PoP cloud eligibility with MSAL.NET: allow Azure Gov + cur…
Robbie-Microsoft Jul 8, 2026
d576db6
Wrap non-base64 x5c decode as CertificateException in mTLS binding cert
Robbie-Microsoft Jul 8, 2026
683e54e
Harden SNI mTLS PoP E2E: prove real resource usability, skip off-CI, …
Robbie-Microsoft Jul 30, 2026
3858dc3
Assert mtls_pop directly in E2E; drop skip-on-downgrade escape hatch
Robbie-Microsoft Jul 30, 2026
d22059a
Exercise regional mtlsauth endpoint on the deterministic Bearer E2E cell
Robbie-Microsoft Jul 30, 2026
48fd92d
Merge origin/dev into rginsburg/sni-mtls-pop (resync mTLS PoP with base)
Robbie-Microsoft Jul 30, 2026
29fc91b
Surface Graph error body on non-2xx in mTLS PoP resource-call helper
Robbie-Microsoft Jul 30, 2026
1805895
Set explicit Accept header in mTLS PoP resource call to avoid Graph 400
Robbie-Microsoft Jul 31, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/copilot-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
- Acquire access tokens for protected APIs (Microsoft Graph, custom APIs)
- Token caching and automatic refresh
- Support for various authentication flows (interactive, silent, client credentials, on-behalf-of, device code, managed identity)
- mTLS Proof-of-Possession (PoP) tokens for confidential clients using an SN/I certificate (see Client Credentials)
- Multi-cloud and B2C support

### Repository Structure
Expand Down Expand Up @@ -137,6 +138,7 @@ MSAL4J supports multiple authentication flows, each with a public `*Parameters`
- **Parameters**: `ClientCredentialParameters` - App-only authentication (daemon apps)
- **Internal**: `ClientCredentialRequest` → `AcquireTokenByClientCredentialSupplier`
- **Key Classes**: `IClientCredential`, `ClientSecret`, `ClientCertificate`, `ClientAssertion`
- **mTLS Proof-of-Possession (PoP)**: Opt in with `ClientCredentialParameters.builder(...).mtlsProofOfPossession()` to obtain an mTLS-bound PoP token (`token_type=mtls_pop`). The app's SN/I `IClientCertificate` is presented as the client TLS certificate to a rewritten `mtlsauth.*` endpoint (no `client_assertion` on the direct path) instead of signing an x5c assertion (the existing SNI+Bearer path is unchanged). Requires a tenanted authority and an ESTS allow-listed resource; region is optional (global `mtlsauth.microsoft.com` when absent). The result exposes `metadata().tokenType()` and `metadata().bindingCertificate()` (public material only — x5c chain + `x5t#S256`). - **Key Classes**: `TokenType`, `BindingCertificate`, `MtlsClientCertificateHelper`, `MtlsEndpointHelper`; internal `AuthScheme`. Not supported: US Gov / China clouds, and user-scoped (`user_fic`) FIC over mTLS.
Comment thread
Robbie-Microsoft marked this conversation as resolved.
Outdated

**On-Behalf-Of (OBO)**
- **Public API**: `acquireToken(OnBehalfOfParameters)`
Expand Down
1 change: 1 addition & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Version 1.25.0
=============
- Add SN/I certificate support over mTLS Proof-of-Possession (PoP) for confidential clients, presenting the certificate as the client TLS cert to obtain an mTLS-bound token
- Add Federated Managed Identity (FMI) support for client credentials flow (#1025)
- Add User Federated Identity Credential (user_fic) grant type support (#1026)
- Add MSAL client metadata headers to IMDS managed identity requests (#1024)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,186 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

package com.microsoft.aad.msal4j;

import com.microsoft.aad.msal4j.labapi.KeyVaultRegistry;
import com.microsoft.aad.msal4j.labapi.KeyVaultSecretsProvider;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestInstance;

import java.io.IOException;
import java.security.KeyStore;
import java.security.KeyStoreException;
import java.security.NoSuchAlgorithmException;
import java.security.NoSuchProviderException;
import java.security.PrivateKey;
import java.security.UnrecoverableKeyException;
import java.security.cert.CertificateException;
import java.security.cert.X509Certificate;
import java.util.Collections;

import static com.microsoft.aad.msal4j.TestConstants.KEYVAULT_DEFAULT_SCOPE;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;

/**
* End-to-end integration tests for SN/I certificate over mTLS Proof-of-Possession (PoP).
*
* <p>These exercise the primary deliverable of this work: a confidential-client app configured with a
* Subject-Name/Issuer (SN/I) certificate obtains an <b>mTLS-bound PoP access token</b> from Entra ID
* (ESTS), where that same SNI cert is presented as the client TLS certificate in the mutual-TLS
* handshake to the token endpoint (no {@code private_key_jwt} / x5c client assertion on the direct
* path).
*
* <p>The primary scenario is covered:
* <ul>
* <li><b>Direct SNI cert &rarr; mTLS PoP</b> (client credentials), global and regional endpoints.</li>
* </ul>
*
* <p><b>Testability gate (SME note A):</b> ESTS gates mTLS PoP on the <i>final resource audience</i>,
* which must be an ESTS allow-listed resource (e.g. Azure Key Vault or MS Graph) — not the client app.
* Every test below therefore requests a token for an allow-listed resource.
*
* <p>The lab SN/I certificate is <b>non-CNG</b>, so these tests are E2E-runnable in CI/CD using the same
* certificate the pipelines already provision for {@code ClientCredentialsIT} and {@code AgenticIT} (the
* OS keystore alias {@link KeyVaultSecretsProvider#CERTIFICATE_ALIAS}). They require lab credentials and
* network access and only pass in CI (like the other {@code *IT} tests, they are not run by the unit-test
* surefire pass).
*/
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
class MtlsPopIT {

private PrivateKey privateKey;
private X509Certificate publicCertificate;
private IClientCertificate certificate;

@BeforeAll
void init() throws KeyStoreException, NoSuchProviderException, IOException,
NoSuchAlgorithmException, CertificateException, UnrecoverableKeyException {
KeyStore keystore = CertificateHelper.createKeyStore();
keystore.load(null, null);

privateKey = (PrivateKey) keystore.getKey(KeyVaultSecretsProvider.CERTIFICATE_ALIAS, null);
publicCertificate = (X509Certificate) keystore.getCertificate(KeyVaultSecretsProvider.CERTIFICATE_ALIAS);

assertNotNull(privateKey, "Lab private key not found. Ensure the lab cert is installed.");
assertNotNull(publicCertificate, "Lab certificate not found. Ensure the lab cert is installed.");

certificate = ClientCredentialFactory.createFromCertificate(privateKey, publicCertificate);
}

/**
* Direct SNI cert &rarr; mTLS PoP with <b>no region</b> (exercises the global
* {@code mtlsauth.microsoft.com} endpoint). The lab cert is presented as the client TLS certificate;
* the request carries {@code token_type=mtls_pop} and <b>no</b> client assertion. Requests an
* allow-listed resource (Key Vault) so ESTS issues the bound token.
*/
@Test
void acquireTokenClientCredentials_Certificate_MtlsPop() throws Exception {
final String clientId = KeyVaultRegistry.getMsidLabProvider()
.getSecretByName("LabVaultAppID").getValue();

ConfidentialClientApplication cca = ConfidentialClientApplication.builder(clientId, certificate)
.authority(TestConstants.MICROSOFT_AUTHORITY) // tenanted authority (required for mTLS PoP)
.build();

IAuthenticationResult result = cca.acquireToken(ClientCredentialParameters
.builder(Collections.singleton(KEYVAULT_DEFAULT_SCOPE))
.mtlsProofOfPossession()
.build())
.get();

assertMtlsPopResult(result, expectedLabThumbprint());

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Acceptance blocker] This resource call uses the original credential rather than the binding returned by MSAL, so it does not satisfy BIND-01/BIND-07. Return IMtlsBindingContext, use its exact SSLContext for the resource call, verify cnf.x5t#S256, and add rejection cells for no certificate, the wrong scheme and a different certificate.

}

/**
* Direct SNI cert &rarr; mTLS PoP with a region configured (exercises the regional
* {@code <region>.mtlsauth.microsoft.com} endpoint), and verifies the bound token is cached and
* retrieved on a second call.
*/
@Test
void acquireTokenClientCredentials_Certificate_MtlsPop_Regional() throws Exception {
final String clientId = KeyVaultRegistry.getMsidLabProvider()
.getSecretByName("LabVaultAppID").getValue();

ConfidentialClientApplication cca = ConfidentialClientApplication.builder(clientId, certificate)
.authority(TestConstants.MICROSOFT_AUTHORITY)
.azureRegion("westus")
.build();

IAuthenticationResult result = cca.acquireToken(ClientCredentialParameters
.builder(Collections.singleton(KEYVAULT_DEFAULT_SCOPE))
.mtlsProofOfPossession()
.build())
.get();

assertMtlsPopResult(result, expectedLabThumbprint());

// The mTLS-PoP token must be cached under {token_type + cert KeyId} and returned on lookup.
IAuthenticationResult cached = cca.acquireToken(ClientCredentialParameters
.builder(Collections.singleton(KEYVAULT_DEFAULT_SCOPE))
.mtlsProofOfPossession()
.build())
.get();

assertEquals(result.accessToken(), cached.accessToken(),
"Second mTLS-PoP request should return the cached bound token");
}

/**
* Requesting a Bearer token and an mTLS-PoP token for the same scope on the same app must yield two
* distinct tokens (cache isolation on {token_type + cert KeyId}), confirming the PoP path never
* aliases the existing SNI+Bearer path.
*/
@Test
void acquireTokenClientCredentials_BearerAndMtlsPop_AreCacheIsolated() throws Exception {
final String clientId = KeyVaultRegistry.getMsidLabProvider()
.getSecretByName("LabVaultAppID").getValue();

ConfidentialClientApplication cca = ConfidentialClientApplication.builder(clientId, certificate)
.authority(TestConstants.MICROSOFT_AUTHORITY)
.build();

// Existing SNI + Bearer path (unchanged).
IAuthenticationResult bearer = cca.acquireToken(ClientCredentialParameters
.builder(Collections.singleton(KEYVAULT_DEFAULT_SCOPE))
.build())
.get();
assertEquals(TokenType.BEARER, bearer.metadata().tokenType());

// New SNI + mTLS PoP path.
IAuthenticationResult pop = cca.acquireToken(ClientCredentialParameters
.builder(Collections.singleton(KEYVAULT_DEFAULT_SCOPE))
.mtlsProofOfPossession()
.build())
.get();
assertEquals(TokenType.MTLS_POP, pop.metadata().tokenType());

assertNotEquals(bearer.accessToken(), pop.accessToken(),
"Bearer and mTLS-PoP tokens for the same scope must be distinct cache entries");
assertEquals(2, cca.tokenCache.accessTokens.size(),
"Bearer and mTLS-PoP tokens must occupy separate cache entries");
}

private void assertMtlsPopResult(IAuthenticationResult result, String expectedThumbprint) {
assertNotNull(result, "Auth result should not be null");
assertNotNull(result.accessToken(), "Access token should not be null");
assertFalse(result.accessToken().isEmpty(), "Access token should not be empty");
assertEquals(TokenType.MTLS_POP, result.metadata().tokenType(),
"Result token type should be MTLS_POP");

BindingCertificate binding = result.metadata().bindingCertificate();
assertNotNull(binding, "mTLS-PoP result must expose a binding certificate");
assertNotNull(binding.thumbprintSha256(), "Binding certificate must expose its SHA-256 thumbprint");
assertFalse(binding.certificateChain().isEmpty(), "Binding certificate must expose its x5c chain");
assertEquals(expectedThumbprint, binding.thumbprintSha256(),
"Binding certificate thumbprint must match the lab SNI cert (x5t#S256)");
}

private String expectedLabThumbprint() {
return MtlsClientCertificateHelper.computeThumbprintSha256(publicCertificate);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,16 @@ class AcquireTokenByClientCredentialSupplier extends AuthenticationResultSupplie

@Override
AuthenticationResult execute() throws Exception {
// For mTLS Proof-of-Possession, isolate the access token in the cache by the binding certificate's

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Blocker] mtlsProofOfPossession() can be combined with appTokenProvider. A provider token is returned without an mTLS request or response-token-type validation, saved under the certificate hash, and later forcibly relabelled MTLS_POP on a cache hit. Please reject this combination unless the provider contract supplies and validates an atomic binding context and token type.

// KeyId (x5t#S256) in addition to the token_type dimension, so PoP tokens bound to different
// certificates never alias. Stamped before the cache lookup so reads and writes hash identically.
if (clientCredentialRequest.parameters.mtlsProofOfPossession()) {
IClientCertificate bindingCertificate = MtlsClientCertificateHelper.resolveBindingCertificate(
(ConfidentialClientApplication) this.clientApplication, clientCredentialRequest.parameters);
clientCredentialRequest.parameters.bindingCertificateKeyId(
MtlsClientCertificateHelper.computeCertificateKeyId(bindingCertificate));
}

if (clientCredentialRequest.parameters.skipCache() != null &&
!clientCredentialRequest.parameters.skipCache()) {
LOG.debug("SkipCache set to false. Attempting cache lookup");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,13 @@ public class AuthenticationErrorCode {

public static final String INVALID_TIMESTAMP_FORMAT = "invalid_timestamp_format";

/**
* Indicates an error while configuring or performing an mTLS Proof-of-Possession request, such as a
* missing binding certificate, a non-tenanted authority, or an unsupported cloud. For more details,
* see https://aka.ms/msal4j-pop
*/
public static final String MTLS_POP_ERROR = "mtls_pop_error";

/**
* Indicates that instance discovery failed because the authority is not a valid instance.
* This is returned by the instance discovery endpoint when the provided authority host is unknown.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,28 @@ public class AuthenticationResultMetadata implements Serializable {
*/
private CacheRefreshReason cacheRefreshReason = CacheRefreshReason.NOT_APPLICABLE;

/**
* The type of the access token in the {@link AuthenticationResult}, see {@link TokenType} for possible
* values. Defaults to {@link TokenType#BEARER}.
*/
private TokenType tokenType = TokenType.BEARER;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Blocker/compatibility] IAuthenticationResult is explicitly Serializable, but this public metadata type has no pinned UID. serialver changes from 6600853896042983641L at the PR base to 4902369891410840671L here, so previously serialized results fail after upgrade. Please pin the previous UID and add a previous-version deserialization fixture.


/**
* For {@link TokenType#MTLS_POP} results, the certificate the token is bound to (public material only).
* Null for Bearer results.
*/
private BindingCertificate bindingCertificate;

AuthenticationResultMetadata(TokenSource tokenSource, Long refreshOn, CacheRefreshReason cacheRefreshReason) {
this(tokenSource, refreshOn, cacheRefreshReason, TokenType.BEARER, null);
}

AuthenticationResultMetadata(TokenSource tokenSource, Long refreshOn, CacheRefreshReason cacheRefreshReason, TokenType tokenType, BindingCertificate bindingCertificate) {
this.tokenSource = tokenSource;
this.refreshOn = refreshOn;
this.cacheRefreshReason = cacheRefreshReason == null ? CacheRefreshReason.NOT_APPLICABLE : cacheRefreshReason;
this.tokenType = tokenType == null ? TokenType.BEARER : tokenType;
this.bindingCertificate = bindingCertificate;
}

public static AuthenticationResultMetadataBuilder builder() {
Expand All @@ -47,6 +65,22 @@ public CacheRefreshReason cacheRefreshReason() {
return this.cacheRefreshReason;
}

/**
* @return the {@link TokenType} of the access token (e.g. {@link TokenType#BEARER} or
* {@link TokenType#MTLS_POP}). Never null.
*/
public TokenType tokenType() {
return this.tokenType;
}

/**
* @return for {@link TokenType#MTLS_POP} results, the {@link BindingCertificate} (x5c chain +
* SHA-256 thumbprint, public material only) the token is bound to; null for Bearer results.
*/
public BindingCertificate bindingCertificate() {
return this.bindingCertificate;
}

void tokenSource(TokenSource tokenSource) {
this.tokenSource = tokenSource;
}
Expand All @@ -59,10 +93,20 @@ void cacheRefreshReason(CacheRefreshReason cacheRefreshReason) {
this.cacheRefreshReason = cacheRefreshReason;
}

void tokenType(TokenType tokenType) {
this.tokenType = tokenType == null ? TokenType.BEARER : tokenType;
}

void bindingCertificate(BindingCertificate bindingCertificate) {
this.bindingCertificate = bindingCertificate;
}

public static class AuthenticationResultMetadataBuilder {
private TokenSource tokenSource;
private Long refreshOn;
private CacheRefreshReason cacheRefreshReason;
private TokenType tokenType = TokenType.BEARER;
private BindingCertificate bindingCertificate;

AuthenticationResultMetadataBuilder() {
}
Expand All @@ -82,12 +126,22 @@ public AuthenticationResultMetadataBuilder cacheRefreshReason(CacheRefreshReason
return this;
}

public AuthenticationResultMetadataBuilder tokenType(TokenType tokenType) {
this.tokenType = tokenType;
return this;
}

public AuthenticationResultMetadataBuilder bindingCertificate(BindingCertificate bindingCertificate) {
this.bindingCertificate = bindingCertificate;
return this;
}

public AuthenticationResultMetadata build() {
return new AuthenticationResultMetadata(this.tokenSource, this.refreshOn, cacheRefreshReason);
return new AuthenticationResultMetadata(this.tokenSource, this.refreshOn, cacheRefreshReason, tokenType, bindingCertificate);
}

public String toString() {
return "AuthenticationResultMetadata.AuthenticationResultMetadataBuilder(tokenSource=" + this.tokenSource + ", refreshOn=" + this.refreshOn + ", cacheRefreshReason$value=" + this.cacheRefreshReason + ")";
return "AuthenticationResultMetadata.AuthenticationResultMetadataBuilder(tokenSource=" + this.tokenSource + ", refreshOn=" + this.refreshOn + ", cacheRefreshReason$value=" + this.cacheRefreshReason + ", tokenType=" + this.tokenType + ", bindingCertificate=" + this.bindingCertificate + ")";
}
}
}
Loading
Loading