[Az.ServiceFabric] Add Enable-AzServiceFabricManagedClusterMaintenanceWindow cmdlet#29538
Open
iliu816 wants to merge 4 commits intoAzure:mainfrom
Open
[Az.ServiceFabric] Add Enable-AzServiceFabricManagedClusterMaintenanceWindow cmdlet#29538iliu816 wants to merge 4 commits intoAzure:mainfrom
iliu816 wants to merge 4 commits intoAzure:mainfrom
Conversation
Add new cmdlet to apply the maintenance window on Service Fabric Managed Clusters immediately. This wraps the applyMaintenanceWindow API which triggers any pending updates to be applied right away. Changes: - New cmdlet EnableAzServiceFabricManagedClusterMaintenanceWindow.cs - Help documentation and module help index - Module manifest updated with new export - ChangeLog entry - Scenario test with session recording (deploys maintenance configuration and verifies applyMaintenanceWindow succeeds) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Az.ServiceFabric cmdlet, Enable-AzServiceFabricManagedClusterMaintenanceWindow, which wraps the Service Fabric Managed Clusters applyMaintenanceWindow API so users can immediately apply an assigned maintenance window (triggering pending updates).
Changes:
- Added the new cmdlet implementation and exported it from the module manifest.
- Added/updated markdown help content and updated the module help index.
- Added a new scenario test (PowerShell + xUnit hook) to validate the cmdlet behavior.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ServiceFabric/ServiceFabric/help/Enable-AzServiceFabricManagedClusterMaintenanceWindow.md | New cmdlet reference help page. |
| src/ServiceFabric/ServiceFabric/help/Az.ServiceFabric.md | Adds the cmdlet to the module help index. |
| src/ServiceFabric/ServiceFabric/Commands/ManagedClusters/ManagedClusters/EnableAzServiceFabricManagedClusterMaintenanceWindow.cs | Implements the new cmdlet that calls ManagedApplyMaintenanceWindow. |
| src/ServiceFabric/ServiceFabric/ChangeLog.md | Adds an Upcoming Release entry for the new cmdlet. |
| src/ServiceFabric/ServiceFabric/Az.ServiceFabric.psd1 | Exports the new cmdlet from the module. |
| src/ServiceFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersTests.ps1 | Adds a scenario test that provisions a cluster, assigns a maintenance configuration, and applies the window. |
| src/ServiceFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersTests.cs | Wires the new PowerShell scenario test into the xUnit test runner. |
Collaborator
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
fix shouldprocess message Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Collaborator
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
Please resolve the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add new
Enable-AzServiceFabricManagedClusterMaintenanceWindowcmdlet that wraps theapplyMaintenanceWindowAPI for Service Fabric Managed Clusters. This allows users to apply the maintenance window, triggering any pending updates.Mandatory Checklist
Please choose the target release of Azure PowerShell.
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriately - Done