Closed
fix(agents): make invocations_ws protocol priority order-independent in loadServiceProtocol#9189
Conversation
|
Azure Pipelines: 20 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: v1212 <49907914+v1212@users.noreply.github.com>
Co-authored-by: v1212 <49907914+v1212@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comment 9009
fix(agents): make invocations_ws protocol priority order-independent in loadServiceProtocol
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadServiceProtocolreturnedinvocations_wsimmediately on match, making protocol selection order-dependent:--protocol invocations_ws --protocol responsesclassified the agent as WebSocket-only (suppressing invoke hints), while the reversed order correctly returnedresponses.Changes
nextstep/state.go: Replace the earlyreturn ProtocolInvocationsWSwith asawInvocationsWStracking variable (mirroring the existingsawInvocationspattern). Priority is now order-independent:responses>invocations>invocations_ws. Updated doc comment to reflect the full priority chain.nextstep/state_test.go: Two regression cases covering the reversed-order scenarios:invocations_wsdeclared beforeresponses→ still returnsresponsesinvocations_wsdeclared beforeinvocations→ still returnsinvocations