Skip to content

feat: update to acr-mirror 1.0.0#8799

Open
juliusl wants to merge 6 commits into
mainfrom
pr/acr-mirror-1.0.0
Open

feat: update to acr-mirror 1.0.0#8799
juliusl wants to merge 6 commits into
mainfrom
pr/acr-mirror-1.0.0

Conversation

@juliusl

@juliusl juliusl commented Jun 30, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Updates acr-mirror to 1.0.0. Update install/enable paths.

Which issue(s) this PR fixes:

Fixes #

Copilot AI review requested due to automatic review settings June 30, 2026 21:05
@github-actions github-actions Bot added the components This pull request updates cached components on Linux or Windows VHDs label Jun 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread parts/linux/cloud-init/artifacts/cse_config.sh Outdated
Comment thread parts/linux/cloud-init/artifacts/cse_config.sh Outdated
Comment thread vhdbuilder/packer/install-dependencies.sh
Comment thread vhdbuilder/packer/install-dependencies.sh
Comment thread parts/linux/cloud-init/artifacts/cse_config.sh Outdated
Comment thread parts/common/components.json
Copilot AI review requested due to automatic review settings July 3, 2026 00:12
@juliusl juliusl force-pushed the pr/acr-mirror-1.0.0 branch from 51dc9d4 to 52d9ba1 Compare July 3, 2026 00:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread spec/parts/linux/cloud-init/artifacts/cse_config_spec.sh Outdated
Comment thread parts/common/components.json
Copilot AI review requested due to automatic review settings July 3, 2026 00:16
@juliusl juliusl force-pushed the pr/acr-mirror-1.0.0 branch from 52d9ba1 to 5e306bc Compare July 3, 2026 00:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

spec/parts/linux/cloud-init/artifacts/cse_config_spec.sh:27

  • These tests create and delete real stub executables under /opt/acr/.... That can be brittle if the shellspec runtime ever includes real acr-mirror files (the tests would overwrite/remove them) or if tests are run without permission to write /opt. Consider adjusting ensureArtifactStreaming to allow overriding the binary paths (e.g., via env vars) and then use a temp directory in the tests instead of mutating /opt.
            The output should include "AKS_GPU_PREBAKE event=managed_gpu"
            The output should include "marker_present=false"

Comment thread parts/linux/cloud-init/artifacts/cse_config.sh Outdated
Copilot AI review requested due to automatic review settings July 3, 2026 00:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread spec/parts/linux/cloud-init/artifacts/cse_config_spec.sh
Comment thread parts/linux/cloud-init/artifacts/cse_config.sh
juliusl added 6 commits July 2, 2026 17:34
Signed-off-by: Julius <juliusl@microsoft.com>
Signed-off-by: Julius <juliusl@microsoft.com>
…to CSE config script

Signed-off-by: Julius <juliusl@microsoft.com>
Signed-off-by: Julius <juliusl@microsoft.com>
Signed-off-by: Julius <juliusl@microsoft.com>
@juliusl juliusl force-pushed the pr/acr-mirror-1.0.0 branch from 2b09909 to 8c937c6 Compare July 3, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

components This pull request updates cached components on Linux or Windows VHDs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants