Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions “Deploy to Azure” workflow to use azure/login for Azure auth and streamlines provisioning by driving deployment through azd up with explicit azd env selection/creation.
Changes:
- Replaced the previous federated login command block with an
azure/login@v2step. - Switched AZD authentication/provisioning steps to
bash, adding logic to select or create an AZD environment and then runazd up --no-prompt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions Azure deployment workflow to use OIDC-based Azure login and a more explicit azd environment selection/creation flow, improving CI onboarding and reliability for deployments.
Changes:
- Adds an explicit
azure/login@v2step before running azd commands. - Switches azd authentication and provisioning steps to
bashand updates the azd commands to select/create an environment and runazd up --no-prompt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
This PR contains onboarding and deployment flow fixes across the azd hooks and CI, aiming to reduce provisioning failures (AKS version drift, quota awareness) and make hook scripts more robust.
Changes:
- Bump the default AKS Kubernetes version in infra parameters and add preprovision validation/fallback logic.
- Add quota-aware VM SKU selection (Bash + PowerShell), including new helpers for safer
az/azd env setusage and stricter shell error handling. - Update the GitHub Actions deploy workflow steps and adjust README section headings.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| infra/main.parameters.json | Updates default Kubernetes version parameter. |
| hooks/validate-env.sh | Uses set -eo pipefail for safer Bash execution. |
| hooks/preprovision.sh | Adds AKS version validation, quota-aware VM menus, and persists Foundry flag. |
| hooks/preprovision.ps1 | Mirrors AKS version validation and quota-aware VM menus in PowerShell. |
| hooks/predown.sh | Uses set -eo pipefail for safer Bash execution. |
| hooks/postup.sh | Uses set -eo pipefail for safer Bash execution. |
| hooks/postprovision.sh | Uses set -eo pipefail and switches to non-fatal azd env persistence helper. |
| hooks/postprovision.ps1 | Uses shared helpers for az JSON parsing and azd env set. |
| hooks/config.sh | Adds max node count defaults and aligns Foundry default with infra. |
| hooks/config.ps1 | Adds max node count defaults and aligns Foundry default with infra. |
| hooks/common.sh | Adds azd_env_set, adds quota map + quota annotation/filtering, and extends VM size data with family/quota fields. |
| hooks/common.ps1 | Adds Invoke-AzJson / Invoke-AzdEnvSet, includes quota-aware filtering/annotation, and extends VM size data with family/quota fields. |
| README.md | Adjusts headings/structure for solution overview and quick deploy sections. |
| .github/workflows/azure-dev.yml | Refactors Azure/AZD login and switches to azd up-based provisioning flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.