refactor(txe): describe oracle types with STRUCT instead of LEAF - #25169
Open
nchamo wants to merge 2 commits into
Open
refactor(txe): describe oracle types with STRUCT instead of LEAF#25169nchamo wants to merge 2 commits into
nchamo wants to merge 2 commits into
Conversation
nchamo
added
ci-draft
nchamo
commented
Aug 11, 2026
| * - TXE_ORACLE_VERSION_MINOR for additive changes (new oracle method added). | ||
| */ | ||
| export const TXE_ORACLE_INTERFACE_HASH = '1a6c578d0a47cd8dd7dae07fd00abe781225a73920c596d873afcc061c0e4284'; | ||
| export const TXE_ORACLE_INTERFACE_HASH = '86d900da6ca21d8dee76b790175aaaee9e865bf99950844e2dc727250fe14a40'; |
Contributor
Author
There was a problem hiding this comment.
Oracles didn't change, so no need to bump versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LEAFmappings: theCompleteAddressreturned bycreate_account/add_account, and the call context returned byget_last_call_context. Both are now composed from the existingSTRUCT/OPTIONcombinators, reusing thePUBLIC_KEYSmapping already defined for PXE.LEAFhides a length or shape change behind a stable label, while a structural label trips the tripwire. The wire format is byte-identical either way, so this is a re-pin of the hash only, with no version bump.get_last_call_contextnow models a tx-less call asOption::none()instead of overloadingFr.ZERO, threaded throughTxeSession.#[generate_oracle_tests_excluding]list and are now covered by the generated serialization tests.