feat(pxe): speculatively sync the predicted callees of sync_state - #25164
Open
nchamo wants to merge 1 commit into
Open
feat(pxe): speculatively sync the predicted callees of sync_state#25164nchamo wants to merge 1 commit into
nchamo wants to merge 1 commit into
Conversation
nchamo
added
ci-draft
nchamo
marked this pull request as ready for review
August 10, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Every contract sync executes the contract's
sync_state, whose own nested calls are learned by the call graph from #25126 but were never predicted:sync_stateis only ever invoked by PXE, so its selector never appears as a sync request's invoked function. Almost all contracts make at least one external call during sync (the handshake registry), so a dependency that always started syncing serially now overlaps — a big win.The change
#startSyncIfNeedednow also fires the speculative sync of the predicted callees of the contract's ownsync_state, keyed under a hardcodedSYNC_STATE_SELECTOR. The selector is safe to hardcode because the macro fixessync_state's signature for every contract; a test derives the expected value from a compiled artifact, so a macro signature change fails loudly instead of silently disabling these predictions.