fix: include standard-contracts historical artifacts in release image - #25155
Merged
spalladino merged 1 commit intoAug 10, 2026
Merged
Conversation
PR #25032 added a top-level import of standard-contracts/artifacts-historical/HandshakeRegistry-5.0.1.json, but the release image dockerignore only whitelists artifacts/, so every node started from a v5-line release image crash-loops at ESM link time with ERR_MODULE_NOT_FOUND. This broke all spartan network deploys from v5-next since 2026-07-29.
Contributor
Author
|
@nchamo does this need porting to v6? |
Contributor
|
No, we don't need to port it to v6. In v6 we'll start "from scratch", without legacy versions. So no need to do this |
nchamo
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #25032,
@aztec/standard-contractshas a top-level import of historical artifact JSONs fromstandard-contracts/artifacts-historical/. The release image dockerignore ignores everything and then whitelists specific paths, and it only whitelistedstandard-contracts/artifacts/— so the historical artifacts never made it into the image.ERR_MODULE_NOT_FOUNDforHandshakeRegistry-5.0.1.json.!/yarn-project/standard-contracts/artifacts-historical/.Split out from #25148 so the deploy fix can land independently of that PR's review. Once this merges, #25148 will be rebased and its duplicate commit will drop out.