Migrate Files Settings screen to Jetpack Compose - #5721
Open
clementiano9 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CloudSettingsFragment(the Files Settings screen) to Jetpack Compose, addingCloudSettingsPageand deletingfragment_cloud_settings.xmlHeadphoneControlsSettingsFragment, reusing the sharedSettingSection/SettingRow/SettingRowToggle/BannercomponentsCloudSettingsViewModelto expose a singleStateFlow<UiState>instead of aLiveDatasign-in state plus directsettings.*.valuereads in the fragment. This also fixes a latent issue: the old screen read each switch value once at bind time, so a preference changed elsewhere (e.g.by sync) while the screen was open would not be reflectedCloudSettingsViewModelTestFixes # 753
Testing Instructions
settings_files_shownon open, and the per-toggle events on each changeScreenshots
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlAutomattic/EventHorizonSchemas/blob/trunk/schema/pocket-casts.yml) to reflect any new or changed analytics.
I have tested any UI changes...