Skip to content

Fix status bar icon contrast in bookmark dialogs #5617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpitagarwal1301 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Fix status bar icon contrast in bookmark dialogs #5617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
* HLS support
([#5602](https://github.com/Automattic/pocket-casts-android/pull/5602))
* Bug Fixes
* Fix status bar icon contrast in light-themed bookmark dialogs
([#2127](https://github.com/Automattic/pocket-casts-android/issues/2127))
* Fix episodes being cached over mobile data when Warn before using data is enabled
([#5567](https://github.com/Automattic/pocket-casts-android/pull/5567))
* Reduce the chance of episode playback progress reverting during listening history sync
Expand Down
2 changes: 1 addition & 1 deletion ...in/java/au/com/shiftyjelly/pocketcasts/player/view/bookmark/BookmarksContainerFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class BookmarksContainerFragment : BaseDialogFragment() {
get() = if (sourceView == SourceView.PROFILE) {
StatusBarIconColor.Theme
} else {
StatusBarIconColor.Light
StatusBarIconColor.ThemeNoToolbar
}

var binding: FragmentBookmarksContainerBinding? = null
Expand Down
Loading