Repository navigation
Conversation
Replace TextControl, TextareaControl and ToggleControl from @wordpress/components with InputControl, TextareaControl and SwitchControl from @wordpress/ui, as flagged by the @wordpress/use-recommended-components lint rule.
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Proposed changes
@wordpress/uicontrols (InputControl,TextareaControl,SwitchControl) instead of the@wordpress/componentsones. This clears the@wordpress/use-recommended-componentslint errors in the package, which also fail on trunk.aria-labelledbyat its visible "Name" label, which would override thearia-label, so these two fields clear it.SwitchControl.No functional change, so the changelog entry is comment-only.
Screenshots
Local site at 1280px wide. Trunk is on the left, this branch on the right.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
call mein Phone. The error shows in red under the field.Definition of done
@wordpress/use-recommended-componentserrors inprojects/packages/seo/_inc.🤖 Generated with Claude Code