Skip to content

SEO: Move the settings and content form controls to @wordpress/ui - #55269

Open
haqadn wants to merge 2 commits into
trunkfrom
update/seo-wordpress-ui-form-controls
Open

haqadn wants to merge 2 commits into
trunkfrom
update/seo-wordpress-ui-form-controls

Conversation

@haqadn

@haqadn haqadn commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

  • The text fields, text areas and switches on the SEO Settings and Content tabs now use the @wordpress/ui controls (InputControl, TextareaControl, SwitchControl) instead of the @wordpress/components ones. This clears the @wordpress/use-recommended-components lint errors in the package, which also fail on trunk.
  • The schema's Organization and Person "Name" fields keep their screen reader names, "Organization name" and "Person name". The new field points aria-labelledby at its visible "Name" label, which would override the aria-label, so these two fields clear it.
  • Error messages under the schema fields stay red. The style now targets the new description element.
  • Nothing else changes visually, apart from slightly less space between a switch's label and its description. That now matches the IndexNow switch, which already uses SwitchControl.

No functional change, so the changelog entry is comment-only.

Screenshots

Local site at 1280px wide. Trunk is on the left, this branch on the right.

Card Before / after
Site visibility Site visibility card
Site verification Site verification card
Schema Schema card with local business on
Schema field errors Phone and price range errors
Author profile Author profile card
Canonical URLs Canonical URLs card
Title structure Title structure card
Front-page description Front-page description card
Content tab Content tab SEO panel

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  1. Go to Jetpack > SEO > Settings and expand every card.
  2. Turn "Add canonical URLs to archive pages" on or off. It saves right away and keeps its state after a reload.
  3. Tab to the "Breadcrumbs" switch in Schema and press Space. It toggles.
  4. In Title structure, click into "Front page" and click a token button such as "Tagline". The token goes in at the caret and the field keeps focus.
  5. In Front-page description, type in "Home page description". The character count updates. Click Save, reload, and the text is still there.
  6. In Site verification, paste a code into "Bing" and click outside the field. Reload, and the code is still there.
  7. In Schema, turn on "This is a local business" and enter call me in Phone. The error shows in red under the field.
  8. In Schema, with "An organization" selected, inspect the Name field in the browser's accessibility panel. Its name is "Organization name". Pick "A person" and it is "Person name".
  9. Go to the Content tab and open a post's SEO panel. Enter an SEO title and turn on "Hide from search engines". "Always include in llms.txt" becomes disabled. Save, reopen the post, and both changes are kept.

Definition of done

  • ESLint reports no @wordpress/use-recommended-components errors in projects/packages/seo/_inc.
  • Every SEO field and switch saves as it does on trunk, and the Name fields keep their screen reader names.
  • Before/after screenshots from a live site are attached.

🤖 Generated with Claude Code

Replace TextControl, TextareaControl and ToggleControl from
@wordpress/components with InputControl, TextareaControl and
SwitchControl from @wordpress/ui, as flagged by the
@wordpress/use-recommended-components lint rule.
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/seo-wordpress-ui-form-controls branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/seo-wordpress-ui-form-controls

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@haqadn
haqadn marked this pull request as ready for review November 19, 2026 21:36
@haqadn
haqadn requested a review from a team as a code owner November 19, 2026 21:36
@haqadn haqadn added the [Status] Needs Review This PR is ready for review. label Nov 19, 2026
@haqadn
haqadn requested a review from chrisbliss18 November 19, 2026 21:36
@haqadn haqadn removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant