Fix player freeze after /freemium with proxy auto-login#3105
Open
lokspel wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Player does /freemium, rejoins — can't move. Rejoins again — works fine,
dialog or session message appears.
Why
After /freemium the backend tells the proxy "this player is no longer premium".
If the player rejoins before the proxy gets that message, the proxy still
sends an auto-login request with the old premium UUID. The backend rejects
it (correctly), but then the code just returned — no login, no limbo,
no dialog, player frozen.
Fix
When the proxy auto-login request is rejected, don't return early —
continue to session check and limbo/dialog like nothing happened
Showcase of Bug
Rejoining after the freemium.
