Repository navigation
fix: recognize Unicode identifiers in binding analysis - #207
Merged
rs545837 merged 1 commit intoOct 28, 2026
Merged
Conversation
There was a problem hiding this comment.
inspect review
Triage: 6 entities analyzed | 0 critical, 0 high, 6 medium, 0 low
Verdict: standard_review
Findings (0)
Reviewed by inspect | Entity-level triage found 0 high-risk changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing non-ASCII call scanner already advances by Unicode character; this closes adjacent byte-oriented paths that could lose names or misclassify boundaries.
Validation
cargo fmt --all -- --checkcargo test --locked -p weave-corecargo clippy --locked -p weave-core --all-targets -- -D warningsAll commands passed in task-local Cargo home/target directories. No CI or review status is asserted.