Fix path separator for remote_zip in computer_client.py#8182
Open
tjc6666666666666 wants to merge 2 commits into
Open
Fix path separator for remote_zip in computer_client.py#8182tjc6666666666666 wants to merge 2 commits into
tjc6666666666666 wants to merge 2 commits into
Conversation
Ensure remote_zip uses forward slashes for compatibility.
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- To avoid potential
//in the path ifSANDBOX_SKILLS_ROOTalready ends with a slash, consider normalizing it, e.g.,remote_zip = f"{SANDBOX_SKILLS_ROOT.rstrip('/')}/skills.zip". - Since this path is intended to be POSIX-style, it may be clearer and more robust to construct it via
PurePosixPath(or a small helper) instead of manual string concatenation so that future call sites remain consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- To avoid potential `//` in the path if `SANDBOX_SKILLS_ROOT` already ends with a slash, consider normalizing it, e.g., `remote_zip = f"{SANDBOX_SKILLS_ROOT.rstrip('/')}/skills.zip"`.
- Since this path is intended to be POSIX-style, it may be clearer and more robust to construct it via `PurePosixPath` (or a small helper) instead of manual string concatenation so that future call sites remain consistent.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the path construction for the sandbox skills bundle in computer_client.py to ensure forward slashes are used for compatibility. The reviewer suggests using the more idiomatic Path.as_posix() method instead of manual string concatenation and recommends translating the Chinese comment into English to maintain consistency with the rest of the codebase.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure remote_zip uses forward slashes for compatibility.
Modifications / 改动点
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Bug Fixes: