Repository navigation
fix: account store ANR and crash hardening for 1.0.11 - #302
Merged
Merged
Conversation
AccountStore reads now come from the volatile snapshot, and writes persist on a serial background thread outside the lock, so the main thread never waits on a writer encoding and encrypting the account blob. Unchanged profile updates no longer rewrite it, and switching accounts stores the previous tokens off the main thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the input-dispatch ANR reported in
AccountStore.get_allon 1.0.11, and hardens the Compose paths most likely behind theIllegalStateExceptioncrashes.AccountStorereads no longer wait on the write lock. Writes are coalesced on a background thread, and unchanged updates are skipped. Switching accounts saves the previous tokens off the main thread.Unit tests: 4,333 passed, including the new
AccountStoreTest.compileFullReleaseKotlinsucceeds.