Skip to content

Disable SSIM on wasm for now #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArthurBrussee merged 1 commit into from
Nov 14, 2024
Merged

Disable SSIM on wasm for now #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/brush-train/src/train.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,8 @@ where

let loss = (pred_compare - batch.gt_images.clone()).abs().mean();

let loss = if self.config.ssim_weight > 0.0 {
// Disabled on WASM for now. On WebGPU + Metal this unfortunately has glitches.
let loss = if self.config.ssim_weight > 0.0 && !cfg!(target_family = "wasm") {
let gt_rgb =
batch
.gt_images
Expand Down
7 changes: 4 additions & 3 deletions crates/brush-viewer/src/panels/scene.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,13 @@ Or load a dataset to train on. These are zip files with:
#[cfg(target_family = "wasm")]
ui.scope(|ui| {
ui.visuals_mut().override_text_color = Some(Color32::YELLOW);
ui.heading("Note: Running in browser is experimental");
ui.heading("Note: Running in browser is still experimental");

ui.label(
r#"
In browser training is about 2x lower than the native app. For bigger training
runs consider using the native app."#,
In browser training is slower, and lower quality than the native app.

For bigger training runs consider using the native app."#,
);
});

Expand Down