Permit larger arguments to combinatorial functions#65
Open
kg583 wants to merge 4 commits into
Open
Conversation
|
|
Member
|
Hi! Thanks for the fix, could you add a test with your example inside tests/math-tests.ark? Since the implementation of the functions you modified changed, I'd argue you can add yourself to the authors (add a comma after the url in @author and add your gh profile, if you want to appear as a co author). |
Author
|
Whoops, thought I already committed that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies
permutationsandbinomialCoeffto do less division, reducing precision loss from floats when the answer can be faithfully represented as an integer.Current:
(binomialCoeff 90 13) == 1643385429346678.5This patch:
(binomialCoeff 90 13) == 1643385429346680(dunno how ArkDoc authorship works when patching something)