Repository navigation
feat: bind validator PoP to chainId and registrantAddress - #186
Merged
Merged
Conversation
shahin-hq
commented
Oct 5, 2026
| 'coincurve', | ||
| 'pycryptodomex', | ||
| 'btclib', | ||
| 'btclib==2023.7.12', |
Author
There was a problem hiding this comment.
btclib was unpinned, so CI installed whatever was newest. Releases from 2026.9.29 onward no longer ship btclib.mnemonic, which crypto/identity/bls_private_key.py imports (from btclib.mnemonic import bip39). As a result, every BLS-related test failed at import on fresh installs.
2023.7.12 is the newest release that still supports Python 3.9 (all 2026.x releases require ≥3.10). Our CI matrix covers 3.9–3.12, so this is the only version that installs on all of them. On 3.9, pip was already resolving to it anyway.
chainId and registrantAddress
shahin-hq
marked this pull request as ready for review
October 5, 2026 13:43
ItsANameToo
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://app.clickup.com/t/2570579/86e3gp5da
validator_proof(passphrase, registrant_address)in place ofvalidator_passphrase(passphrase). The encoder helpers also take the address.Checklist