Repository navigation
refactor(snapshot-legacy-importer): clean up the importer and add unit tests - #1525
Merged
sebastijankuzner merged 10 commits intoOct 9, 2026
Merged
Conversation
oXtxNt9U
added this pull request to stack #1526
October 9, 2026 04:18
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1525 +/- ##
===========================================
+ Coverage 80.39% 80.80% +0.40%
===========================================
Files 952 962 +10
Lines 17178 17663 +485
Branches 2611 2739 +128
===========================================
+ Hits 13810 14272 +462
- Misses 3363 3383 +20
- Partials 5 8 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sebastijankuzner
force-pushed
the
refactor/snapshot-legacy-importer/cleanup
branch
from
October 9, 2026 13:14
2577cd5 to
3ab1007
Compare
Base automatically changed from
fix/snapshot-legacy-importer/resigned-validators
to
develop
October 9, 2026 13:22
sebastijankuzner
force-pushed
the
refactor/snapshot-legacy-importer/cleanup
branch
from
October 9, 2026 13:22
3ab1007 to
42ed2ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
<hash>.compressed). The unused.jsonpath is removed, read failures name the file, and theconsoleoutput is gone.import(). It compared the prepared wallet list against itself, so it could never fail.LegacyImporter.totalSupplyand.result,arkAddress/publicKeyon imported voters and validators, and the emptydefaults.ts.import()now rejects an import beforeprepare()or a second import, anddispose()resets all state.run()errors now name what didn't match: snapshot hash vs. milestone, chain tip vs. genesis parent hash, or a missing snapshot milestone.Checklist