Skip to content

fix(snapshot-legacy-importer): respect resigned attribute when importing delegates - #1523

Merged
sebastijankuzner merged 2 commits into
developfrom
fix/snapshot-legacy-importer/resigned-validators
Oct 9, 2026
Merged

sebastijankuzner merged 2 commits into
developfrom
fix/snapshot-legacy-importer/resigned-validators

Conversation

@oXtxNt9U

@oXtxNt9U oXtxNt9U commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Summary

The legacy importer read delegate.isResigned from the snapshot, but ARK V3 stores the flag as delegate.resigned. isResigned only exists in V3's API output. As a result, every resigned V3 delegate was imported as an active validator, with its votes.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.67%. Comparing base (9a9454a) to head (b04a3ae).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1523      +/-   ##
===========================================
+ Coverage    80.32%   80.67%   +0.35%     
===========================================
  Files          952      963      +11     
  Lines        17166    17613     +447     
  Branches      2602     2687      +85     
===========================================
+ Hits         13788    14210     +422     
- Misses        3373     3395      +22     
- Partials         5        8       +3     
Flag Coverage Δ
contracts 91.95% <ø> (?)
packages 80.39% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oXtxNt9U
oXtxNt9U added this pull request to stack #1526 October 9, 2026 04:18
@sebastijankuzner
sebastijankuzner force-pushed the fix/snapshot-legacy-importer/resigned-validators branch from d7f1c55 to b04a3ae Compare October 9, 2026 13:14
@sebastijankuzner
sebastijankuzner merged commit 668d31b into develop Oct 9, 2026
26 checks passed
@sebastijankuzner
sebastijankuzner deleted the fix/snapshot-legacy-importer/resigned-validators branch October 9, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants