Repository navigation
fix(snapshot-legacy-importer): respect resigned attribute when importing delegates - #1523
Merged
sebastijankuzner merged 2 commits intoOct 9, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1523 +/- ##
===========================================
+ Coverage 80.32% 80.67% +0.35%
===========================================
Files 952 963 +11
Lines 17166 17613 +447
Branches 2602 2687 +85
===========================================
+ Hits 13788 14210 +422
- Misses 3373 3395 +22
- Partials 5 8 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oXtxNt9U
added this pull request to stack #1526
October 9, 2026 04:18
sebastijankuzner
force-pushed
the
fix/snapshot-legacy-importer/resigned-validators
branch
from
October 9, 2026 13:14
d7f1c55 to
b04a3ae
Compare
sebastijankuzner
deleted the
fix/snapshot-legacy-importer/resigned-validators
branch
October 9, 2026 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The legacy importer read
delegate.isResignedfrom the snapshot, but ARK V3 stores the flag asdelegate.resigned.isResignedonly exists in V3's API output. As a result, every resigned V3 delegate was imported as an active validator, with its votes.Checklist