Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1521 +/- ##
===========================================
+ Coverage 80.31% 80.62% +0.31%
===========================================
Files 952 963 +11
Lines 17162 17620 +458
Branches 2599 2698 +99
===========================================
+ Hits 13784 14207 +423
- Misses 3373 3405 +32
- Partials 5 8 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The transaction deserializer accepted some encodings that re-serialize to different bytes. Nodes rebuild stored transactions with the serializer when serving blocks, so a validator could commit a block whose served bytes no longer match its
payloadSize, and syncing nodes would reject that block forever.Fixes
<<wrapped overlong length prefixes to valid lengths.Tests
deserializer.fuzz.test.ts: a seeded fuzz test checking that every accepted encoding re-serializes to identical bytes. It runs 10,000 random cases plus fixed boundary inputs.FUZZ_SEED/FUZZ_RUNSreproduce a failure or run a longer campaign.Checklist