Repository navigation
fix(consensus): bind the BLS proof-of-possession to the chain and registrant - #1506
Merged
Merged
Conversation
oXtxNt9U
added this pull request to stack #1507
September 29, 2026 05:59
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1506 +/- ##
===========================================
+ Coverage 79.74% 80.09% +0.35%
===========================================
Files 954 965 +11
Lines 17089 17567 +478
Branches 2530 2606 +76
===========================================
+ Hits 13627 14070 +443
- Misses 3457 3489 +32
- Partials 5 8 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oXtxNt9U
force-pushed
the
fix/consensus/bls-pop-binding
branch
from
September 29, 2026 09:25
554587e to
b217253
Compare
sebastijankuzner
force-pushed
the
fix/consensus/bls-pop-binding
branch
from
September 29, 2026 09:51
b217253 to
19bb58e
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerValidator/updateValidatoraccept any(blsPublicKey, proofOfPossession)pair from any sender. The PoP proves someone holds the key, but not who is registering it or on which chain.So anyone can copy a pair from the mempool or another network and submit it first. Their registration wins, the key is burned permanently (
BlsKeyAlreadyRegistered) and the real validator's transaction reverts.The fix:
The PoP now signs
chainId ‖ registrantAddress ‖ blsPublicKey, so it is only valid for the address that created it, on one chain:ConsensusV1passesmsg.senderandblock.chainidinto the PoP precompile.buildProofOfPossession(privateKey, { chainId, registrantAddress })builds the matching message.Checklist