Repository navigation
feat: migrate transaction envelope to Mainsail (RLP + ECDSA) - #82
Merged
Merged
Conversation
shahin-hq
marked this pull request as ready for review
July 23, 2026 09:51
ItsANameToo
reviewed
Jul 23, 2026
ItsANameToo
left a comment
Member
There was a problem hiding this comment.
can you add an implementation to https://github.com/ArdentHQ/sdk-tester-scripts to see it in action @shahin-hq ? that will make testing easier too
Author
Would you mind if I do that after having this one merged, because I'll implement tx builders in the next PR which will enable us testing? |
ItsANameToo
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://app.clickup.com/t/2570579/86e2fc2w4
RlpBytes/RlpBigInt/RlpListencode/decode, no external dependencyTransactionstruct - EVM-shaped fields (Nonce/GasPrice/GasLimit/To/Value/Data/V/R/S/...) replacing the old asset-based modelSign,RecoverSender,Verify,GetHash,SigningHashbtcsuite/btcdandellemouton/schnorrentirely; move todecred/dcrd/dcrec/secp256k1/v4directly; upgradegolang.org/x/crypto,testifyChecklist