Repository navigation
refactor: use coingecko as the default market provider - #219
Merged
Merged
Conversation
goga-m
marked this pull request as ready for review
July 3, 2026 08:56
6 tasks
ItsANameToo
reviewed
Jul 3, 2026
Comment on lines
+7
to
+11
| { | ||
| "id": "arken-world", | ||
| "symbol": "dark", | ||
| "name": "Dark" | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Ah good catch. This is a stale test fixture pulled from https://api.coingecko.com/api/v3/coins/list. I let AI generate it and forgot to filter out the noise. It should be corrected now.
goga-m
marked this pull request as draft
July 3, 2026 09:19
goga-m
marked this pull request as ready for review
July 3, 2026 11:00
Contributor
Author
|
@ItsANameToo I also removed the cryptocompare references form the codebase as we discussed. |
ItsANameToo
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for https://app.clickup.com/t/2570579/86e214efn
Cryptocompare no longer provides a free tier for rates. This PR is setting the coingecko as default market provider, and drops the cryptocompare service as it's no longer in use.