Repository navigation
refactor: improve address component truncation - #1926
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
goga-m
marked this pull request as ready for review
October 2, 2026 14:05
goga-m
requested review from
ItsANameToo,
alexbarnsley,
boldninja and
samharperpittam
as code owners
October 2, 2026 14:05
6 tasks
ItsANameToo
requested changes
Oct 5, 2026
ItsANameToo
left a comment
ItsANameToo
left a comment
Contributor
There was a problem hiding this comment.
see video in slack: can we make sure the size of the addressing column entries doesn't change when transactions refresh? To keep it consistent when widths don't change
ItsANameToo
marked this pull request as draft
October 5, 2026 08:45
Contributor
Author
|
A couple of offenders for that particular case with the resize glitch, the tx rows was re-rendering multiple times causing the middle truncation resize observer to fire in a loop, something that was not happening on initial render, and it was tricky to spot. I adjusted the logic in the resize observer and the middle truncation component, it should be working now. lmk |
goga-m
marked this pull request as ready for review
October 8, 2026 10:12
ItsANameToo
approved these changes
Oct 12, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://app.clickup.com/t/2570579/86e3hzx4k
Checklist