Feature/mac os adaptation#179
Open
f-brinkmann wants to merge 5 commits into
Open
Conversation
f-brinkmann
commented
Apr 24, 2026
| LAPACKFLAG=-DUSE_LAPACK | ||
| OPTIM=-O2 | ||
| LDFLAGS=-llapacke -lgsl -lblas | ||
| GSL_PREFIX ?= /usr/local |
Contributor
Author
There was a problem hiding this comment.
This allows to pass custom GSL paths. Was required when istalling with brew on mac
f-brinkmann
commented
Apr 24, 2026
| else | ||
| else { | ||
| // Ylev[lev-1][i * Ncurrent + j] += (2.0 * double(l) + 1.0) / (4.0 * PI) * legendre(l,Angle); | ||
| #ifdef USE_GSL |
Contributor
Author
There was a problem hiding this comment.
This call was not encapsulated. LMM suggested the gsl_sf_legendre_PL call. Can you verify that this is correct?
| #include<vector> | ||
| #include <bits/stdc++.h> | ||
| //#include<x86_64-linux-gnu/cblas64_mangling.h> | ||
| #include<cmath> |
Contributor
Author
There was a problem hiding this comment.
LMM suggested an explicit import of math instead of bits/stdc++.h which works in linux but not in mac
| #include <bits/stdc++.h> | ||
| //#include<x86_64-linux-gnu/cblas64_mangling.h> | ||
| #include<cmath> | ||
| #include<gsl/gsl_cblas.h> |
Contributor
Author
There was a problem hiding this comment.
LMM suggested that this gsl include is system agnocistc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See files changed for explanations of the changes.
When running
makeI stil get one error: