Repository navigation
fix(cli): report failed skills installs instead of claiming success - #1290
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c252d49ff0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe CLI records failures from optional setup steps and includes them in project creation results. It collects skill installation errors, cleans up reserved package directories after addon setup failures, and updates skill sources and recommendations. ChangesCLI setup failure reporting
Priority: ➖ Normal Severity of issue fixed: Medium Merge Risk: 🔵 Low · up to
|
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
b3c2e9d6-eff5-4d44-9a86-7b80fdb47dd6
📒 Files selected for processing: 6
apps/cli/src/helpers/addons/skills-setup.tsapps/cli/src/helpers/core/add-handler.tsapps/cli/src/helpers/core/command-handlers.tsapps/cli/src/helpers/core/create-project.tsapps/cli/src/utils/interrupt.tsapps/cli/src/utils/optional-step.ts
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
14bac925-3c2a-4a7a-9598-a08b617e0c03
📒 Files selected for processing: 3
apps/cli/src/helpers/core/add-handler.tsapps/cli/src/utils/context.tsapps/cli/src/utils/interrupt.ts
🚧 Files skipped from review as they are similar to previous changes: 1
- apps/cli/src/utils/interrupt.ts
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
If the reserved package directory can't be removed after a failed add, the error now says so and asks the user to delete it, since the leftover directory makes the next add with the same name fail.
Checked every curated skill against `skills add <source> --list`: - Convex: 7 of the 9 skills in waynesutton/convexskills no longer exist. Switch to Convex's official get-convex/agent-skills: convex, convex-design, convex-docs, convex-reviewer, convex-authz, convex-crons, convex-migrate, convex-env and convex-test. - Expo: expo-tailwind-setup was removed upstream. - Prisma: prisma-database-setup and prisma-postgres are now deprecated aliases; use prisma-orm-setup and prisma-postgres-setup. All other sources still publish every curated name.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
02a1be40-8062-401e-9613-96c3f7186d5f
📒 Files selected for processing: 2
apps/cli/src/helpers/addons/skills-setup.tspackages/types/src/schemas.ts
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.
…kills Projects created before the Convex source change store waynesutton/convexskills in bts.jsonc, which the schema no longer accepts, so add reported no project found. Map the legacy source and its skill names to the current ones when reading the config, the same way the old Hono source is handled; add then saves the migrated selection.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
d88fc0d0-073b-4633-9a68-0b64380552cb
📒 Files selected for processing: 2
apps/cli/src/utils/bts-config.tsapps/cli/test/add-project.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.
The CLI targets the latest scaffold only, so bts.jsonc is read as is instead of rewriting the old Hono and Convex skill sources.
Summary
When
skills@latest addexited non-zero (e.g. an unknown skill name), the skills addon only logged a dim warning, the spinner still said "Skills installed", andadd-jsonreturned"success": truewith exit code 0.setupSkillsnow collects per-source failures, stops the spinner with "Failed to install skills" and returns anAddonSetupErrorcontaining the underlying command error (including its stderr).runOptionalSteprecords failed steps (alongside the existing interrupt tracking), so silent/JSON callers can see them instead of the error being dropped.add/add-json: a failed addon setup step now fails the command (exit 1, error text in the CLI error /success: false+errorfor programmatic callers), andbts.jsoncis not updated with the failed addon. This matches how otheraddsetup errors already behave, andaddhas no other purpose than setting up the requested addons.create/create-json: the project is still created (addon setup stays an optional post-scaffold step, as for the other addons), but failed steps are now listed inwarnings.Fixes #1096
Outdated curated skills
Many of these failures came from our own defaults. I checked every curated skill against
skills add <source> --list:waynesutton/convexskillsno longer exist, so every Convex project with the skills addon failed. The source is now Convex's officialget-convex/agent-skills, withconvex,convex-design,convex-docs,convex-reviewer,convex-authz,convex-crons,convex-migrate,convex-envandconvex-test.expo-tailwind-setupwas removed upstream.prisma-database-setupandprisma-postgresare now deprecated aliases. They're replaced byprisma-orm-setupandprisma-postgres-setup.Every other source still publishes all of its curated names. With the default selection,
add-jsoninstalls all skills cleanly into a Next.js + Expo + Convex project and a Prisma project.Verification
bun run checkcd apps/cli && AGENT=1 BTS_TELEMETRY=0 bun run test:ci(112 pass)add-jsonwithselections: [{ source: "vercel-labs/agent-skills", skills: ["does-not-exist-xyz"] }]-> exit 1, error includesFailed to install skills from vercel-labs/agent-skills: Command failed with exit code 1 ... No matching skills found for: does-not-exist-xyz; no.claudefolder,bts.jsoncunchanged.web-design-guidelines->"success": true,.claude/skills/web-design-guidelinesinstalled.create-jsonwith the bad skill ->success: truewith the install error inwarnings.add --addons skills(driven through a pty, with a failingnpxonPATH) -> spinner shows "Failed to install skills", each source's error is printed, ends with "Addon setup failed", exit 1.BTS_SKIP_EXTERNAL_COMMANDS=1, sosetupSkillsnever runs the skills CLI in tests, and exercising it would need network access.Summary by CodeRabbit