test(cli): canonicalize temporary paths on macOS - #138
Open
en-ver wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TMP_ROOTwith physicalpwd -P; strict command/CWD/argv assertions stay unchanged.Root cause
On macOS,
/varresolves to/private/var;mktemp -dreturns logical/var/folders/..., while a Bun-spawned shell's$PWDreports physical/private/var/folders/.... Raw equality fails despite the same directory and correct command order and arguments.Solution rationale
Canonicalize the scratch root once before deriving fixtures, aligning the path vocabulary at the test boundary rather than changing production behavior or weakening assertions. This follows existing upstream portability practice.
Validation
bun test ./bridge ./cli ./scripts: 3,201 passed.scripts/collie-ctl.test.sh: passed.NODE_OPTIONS=--no-experimental-webstorage./proclimitation; this is not a claim that the complete CLI shell suite is green on macOS.