Also search for dylibs in case we are on Darwin#169
Open
luke-clifton wants to merge 1 commit intoAltF02:masterfrom
Open
Also search for dylibs in case we are on Darwin#169luke-clifton wants to merge 1 commit intoAltF02:masterfrom
luke-clifton wants to merge 1 commit intoAltF02:masterfrom
Conversation
Author
|
Sorry, meant to mention, I will add the dylibs to all the loading paths if this approach is acceptable. |
248e718 to
cf702b7
Compare
Owner
|
Apologies for my absence, unfortunately I'm unable to test Darwin. Maybe an idea to use the cfg attribute? E.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to usersI have a use case where I want to run X11 applications on Darwin (using Xquartz). I've tested this change on Linux and MacOS.
I didn't introduce a conditional here, though I can if that is preferred, just let me know.
I did not run
cargo fmton this branch because it made changes elsewhere in the code. The part I added is unchanged bycargo fmt.