feat: player abilities APIs by zernix2077 · Pull Request #843 · AllayMC/Allay

zernix2077 · 2026-03-14T19:38:06Z

Massive ability refactor.

Replaces old hardcoded game mode and permission checks with a server-tracked PlayerAbility set on each player. Abilities are now part of the player API, broadcasted to all clients, validated server-side, and persisted in player data.

The new system adds explicit ability state tracking and validating for all vanilla abilities like building and mining. Players now expose ability-focused APIs such as setAbility, setAbilities, hasAbility, client-synced gamemode-aware checkers such as canBuild, canMine, canOpenContainers, ability setters such as setCanFly, setCanMine. Maps cleanly to operator and gamemode updates.

Also improves enforcement and fixes several gameplay/security issues: blocks cannot be placed in adventure mode now, all world interactions are prevented in spectator mode, player abilities and permission are globally broadcasted and can be modified by operators.

Additional changes:

Added setImmutableWorld, which maps to UpdateAdventureSettingsPacket#immutableWorld (active in adventure and spectator modes)
Added setAlwaysFlying, which keeps the client in flight (active in spectator mode)

Events:

PlayerAbilitiesUpdateEvent fires after a player’s abilities change
PlayerAbilitiesUpdateRequestEvent fires when an operator requests an ability update for another player through the client permission UI

Breaking changes:

Removed Permissions.ABILITY_FLY_SURVIVAL, Permissions.ABILITY_FLY_CREATIVE, Permissions.ABILITY_FLY_ADVENTURE, since it's now tracked by abilities
Player#viewPlayerPermission(...) renamed to Player#viewPlayerAbilities(...)

codecov · 2026-03-14T20:15:22Z

Codecov Report

❌ Patch coverage is 6.78466% with 316 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...in/java/org/allaymc/server/player/AllayPlayer.java	0.00%	184 Missing ⚠️
...ssor/ingame/RequestPermissionsPacketProcessor.java	0.00%	37 Missing ⚠️
...rocessor/ingame/RequestAbilityPacketProcessor.java	0.00%	14 Missing ⚠️
...ocessor/ingame/PlayerAuthInputPacketProcessor.java	0.00%	13 Missing ⚠️
...c/main/java/org/allaymc/api/player/PlayerData.java	0.00%	12 Missing ⚠️
...or/ingame/InventoryTransactionPacketProcessor.java	0.00%	12 Missing ⚠️
...i/src/main/java/org/allaymc/api/player/Player.java	0.00%	8 Missing ⚠️
...ntbus/event/server/PlayerAbilitiesUpdateEvent.java	0.00%	7 Missing ⚠️
...omponent/player/EntityPlayerBaseComponentImpl.java	0.00%	7 Missing ⚠️
...vent/server/PlayerAbilitiesUpdateRequestEvent.java	0.00%	6 Missing ⚠️
... and 8 more

Files with missing lines	Coverage Δ	Complexity Δ
...allaymc/api/permission/OpPermissionCalculator.java	`14.28% <ø> (-5.72%)`	`1.00 <0.00> (ø)`
...src/main/java/org/allaymc/api/player/GameMode.java	`85.71% <100.00%> (ø)`	`1.00 <0.00> (ø)`
...ain/java/org/allaymc/api/player/PlayerAbility.java	`100.00% <100.00%> (ø)`	`1.00 <1.00> (?)`
...pi/entity/component/EntityPlayerBaseComponent.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...c/server/item/component/ItemBaseComponentImpl.java	`48.40% <0.00%> (ø)`	`46.00 <0.00> (ø)`
...erver/network/processor/PacketProcessorHolder.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
.../org/allaymc/server/player/AllayPlayerManager.java	`16.44% <0.00%> (ø)`	`3.00 <0.00> (ø)`
...g/allaymc/server/container/impl/BaseContainer.java	`84.09% <0.00%> (-1.96%)`	`29.00 <0.00> (ø)`
...erver/container/impl/DoubleChestContainerImpl.java	`73.27% <0.00%> (-1.29%)`	`37.00 <0.00> (ø)`
.../processor/ingame/PlayerActionPacketProcessor.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
... and 11 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

smartcmd · 2026-03-15T08:28:04Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1bc1675f7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

smartcmd · 2026-03-15T10:11:31Z

+     *
+     * @return {@code true} if building is currently allowed, {@code false} otherwise
+     */
+    boolean canBuild();


We don't need the following getter/setter of each individual ability, just let the user use addAbility/removeAbility method to make the Player class clean

getters are not simple ability lookup. even with BUILD ability present, client would still not be able (and thus server should not it allow to) to place blocks if it's in adventure mode, spectator mode, or immutableWorld is sent. getters are aware of this, while hasPermission is separate lookup with different semantics.
setters are purely setters, but with getters setters are usually expected too, and setCanBuild(false) feels cleaner than setAbility(PlayerAbility.BUILD, false), which requires user to know about the abilities API or specific enums, which might even be considered an implementation detail.

…T in favor of Permissions.ABILITY_OPERATOR_COMMAND_QUICK_BAR

smartcmd

Should also rename the newly added methods in Player

smartcmd · 2026-03-15T12:37:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a86bc3bb69

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

zernix2077 · 2026-03-15T12:52:02Z

Should also rename the newly added methods in Player

done

smartcmd · 2026-03-15T17:04:04Z

            removeViewer(viewer);
            return addViewer(viewer);
        }
+        if (viewer instanceof Player player && this instanceof BlockContainer && !player.canOpenContainers()) {


Shouldn't put the check here, Container.addViewer() should always success in my opinion

why addViewer should succeed if player is not allowed to open and view containers?

Handler of ContainerOpenEvent event would literally see event.getPlayer().canOpenContainers() as false, is it really expected behavior?

Maybe add canOpenContainers in container open event?

I'm not really understanding the point of that. why not invoke it when a player tries to open a chest that's blocked by a block above then? maybe plugins should use the block interaction event in such cases?

smartcmd · 2026-03-15T17:04:10Z

            removeViewer(viewer);
            return addViewer(viewer);
        }
+        if (viewer instanceof Player player && !player.canOpenContainers()) {


IWareQ · 2026-05-11T10:28:02Z

Resolve conflicts

codacy-production · 2026-06-07T13:23:13Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 45 complexity

Metric Results

Complexity 45

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

# Conflicts: # api/src/main/java/org/allaymc/api/player/PlayerData.java # server/src/main/java/org/allaymc/server/command/defaults/GameTestCommand.java # server/src/main/java/org/allaymc/server/network/processor/ingame/PlayerAuthInputPacketProcessor.java

zernix2077 · 2026-06-07T13:38:12Z

Resolve conflicts

done

chatgpt-codex-connector Bot reviewed Mar 15, 2026

View reviewed changes

Comment thread server/src/main/java/org/allaymc/server/player/AllayPlayer.java Outdated

Comment thread api/src/main/java/org/allaymc/api/player/PlayerData.java Outdated

smartcmd requested changes Mar 15, 2026

View reviewed changes

zernix2077 force-pushed the ability-refactor branch from 49b7e96 to d876bf9 Compare March 15, 2026 12:00

smartcmd requested changes Mar 15, 2026

View reviewed changes

Comment thread api/src/main/java/org/allaymc/api/eventbus/event/player/PlayerAbilitiesUpdateRequestEvent.java Outdated

Comment thread api/src/main/java/org/allaymc/api/eventbus/event/player/PlayerAbilitiesUpdateEvent.java Outdated

smartcmd requested changes Mar 15, 2026

View reviewed changes

Comment thread api/src/main/java/org/allaymc/api/player/PlayerAbility.java Outdated

smartcmd requested changes Mar 15, 2026

View reviewed changes

Comment thread api/src/main/java/org/allaymc/api/player/PlayerAbility.java Outdated

smartcmd requested changes Mar 15, 2026

View reviewed changes

Comment thread api/src/main/java/org/allaymc/api/player/PlayerAbility.java Outdated

feat: player abilities APIs

70ad58b

zernix2077 force-pushed the ability-refactor branch from 7d606e5 to 70ad58b Compare March 15, 2026 12:14

feat: remove PlayerAbility.OPERATOR_COMMAND and PlayerAbility.TELEPOR…

a86bc3b

…T in favor of Permissions.ABILITY_OPERATOR_COMMAND_QUICK_BAR

smartcmd requested changes Mar 15, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Mar 15, 2026

View reviewed changes

Comment thread server/src/main/java/org/allaymc/server/player/AllayPlayer.java

Comment thread api/src/main/java/org/allaymc/api/player/GameMode.java

feat: better Player ability methods naming

fa18f93

zernix2077 added 3 commits March 15, 2026 19:32

feat: PlayerAbility.NO_BLOCK_CONSUMPTION

e8493da

feat: remove ability setters

60d9f05

feat: rename NO_BLOCK_CONSUMPTION to INFINITE_BLOCK

6a6ce08

zernix2077 force-pushed the ability-refactor branch from 1498d1e to 6a6ce08 Compare March 15, 2026 16:45

smartcmd requested changes Mar 15, 2026

View reviewed changes

fix: ensure flying state sync on abilities update

671a96e

IWareQ approved these changes May 9, 2026

View reviewed changes

zernix2077 force-pushed the ability-refactor branch from 4e7823d to 1c9ae04 Compare June 7, 2026 13:33

IWareQ approved these changes Jun 7, 2026

View reviewed changes

IWareQ merged commit 0a7dd38 into AllayMC:master Jun 7, 2026
2 checks passed

Uh oh!

Conversation

zernix2077 commented Mar 14, 2026

Uh oh!

codecov Bot commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

smartcmd commented Mar 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smartcmd left a comment

Choose a reason for hiding this comment

Uh oh!

smartcmd commented Mar 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

zernix2077 commented Mar 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IWareQ commented May 11, 2026

Uh oh!

codacy-production Bot commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

zernix2077 commented Jun 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Mar 14, 2026 •

edited

Loading

codacy-production Bot commented Jun 7, 2026 •

edited

Loading