[Tools] MlResponse: assure equality of number of checked features to that in the .onnx file#16424
Open
lubynets wants to merge 1 commit into
Open
[Tools] MlResponse: assure equality of number of checked features to that in the .onnx file#16424lubynets wants to merge 1 commit into
lubynets wants to merge 1 commit into
Conversation
|
O2 linter results: ❌ 0 errors, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation of the code, if the number of features to be checked (
mCachedIndicessize) is not equal to the number of features stored in the .onnx file (accessible byOnnxModel::getNumInputNodes()), then:OnnxModel::evalModel()via handling an exception thrown deeper in the stack;This PR proposes to check the mentioned sizes before model application, while model is initialized and throw a
fatalerror if the sizes are not equal.