[PWGHF] Update tree creator for Xic0Omegac0#16421
Conversation
jinhyunni
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#16421
|
You are repeating the same block 11 times! |
| if (fillParticle) { | ||
| rowCandidateParticles.reserve(mcParticles.size()); | ||
| for (const auto& particle : mcParticles) { | ||
| rowCandidateParticles(RecoDecay::m(std::array{particle.px(), particle.py(), particle.pz()}, particle.e()), |
There was a problem hiding this comment.
Why don't you use pVector here?
There was a problem hiding this comment.
Thanks for your advice. I've changed the code to use pVector.
| /// \author Krista Smith <krista.lizbeth.smith@cern.ch>, Pusan National University | ||
|
|
||
| #include "PWGHF/Core/CentralityEstimation.h" | ||
| #include "PWGHF/Core/DecayChannelsLegacy.h" |
There was a problem hiding this comment.
This header was included to give option which provides the input configuration used to filter the MCParticles table. It was introduced to support different decay chains. Please have a look at line 333.
| DECLARE_SOA_COLUMN(MassV0Chi2OverNdf, massV0Chi2OverNdf, float); | ||
| DECLARE_SOA_COLUMN(MassCascChi2OverNdf, massCascChi2OverNdf, float); | ||
| // MC | ||
| DECLARE_SOA_COLUMN(PdgFromMc, pdgFromMc, int); |
There was a problem hiding this comment.
What would a PDG not from MC be?
There was a problem hiding this comment.
Changed the column name into ParticlePdg. If you still have any opinions on this naming, please let me know.
… into updateworkflow
I've written a helper function to fill in particle table to enhance code maintainence. |
…to updateworkflow
3 participants
Modified
treeCreatorToXiPiQa.cxxto support saving an output table with generated-particle information.