fix(mpd): avoid false no-song warning when stopped#5101
Open
SaveTheRbtz wants to merge 1 commit into
Open
Conversation
Author
Contributor
|
I suspect my old hack just had a bug in it, since the log line wasn't gated on checking it was actually stopped. LGTM (not that I have any role here). |
2e0byo
suggested changes
Jun 5, 2026
2e0byo
left a comment
2e0byo
left a comment
Contributor
There was a problem hiding this comment.
LGTM: my original log line should have been gated behind such a check.
(I'm just a random stranger and have no role here, just reviewing as I wrote the previous patch.)
SaveTheRbtz
force-pushed
the
codex-mpd-song-warning
branch
from
4de8844 to
bef7df8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
MPD can legitimately report no current song while stopped. The old condition logged
Bug in mpdfor any missing song, including the normal stopped state, which made routine MPD idle/stopped states look like bugs.Testing
ninja -C buildmeson test -C build