Inlining visualization - #261
Merged
Merged
Conversation
Contributor
|
Wow, this is amazing for debugging 🚀 🔥 |
luc-raz
reviewed
Aug 11, 2026
| self inline: messageSend ] | ||
| sends := cfg messageSends select: [ :send | send hasMissingInlines ]. | ||
|
|
||
| (sends takeFirst: 3) do: [ :messageSend | self inline: messageSend ] |
Contributor
There was a problem hiding this comment.
What the constant 3 means here
Contributor
Author
There was a problem hiding this comment.
Hehe I'm doing experiments, that 3 is a magic number that makes the inlining strategy useful.
However, I'm changing it for a "better heuristic" 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding visualization about inlining methods. Check the video where I play with the Inline optimization:
Screen.Recording.2026-08-07.at.15.20.49.mp4
(red nodes means that there are inlining opportunities. This is a recursive method, so there are always any)