-
Notifications
You must be signed in to change notification settings - Fork 44
Feature/984: bulk update notification email addresses #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuliialikhyt
wants to merge
75
commits into
develop
Choose a base branch
from
feature/984-feature-bulk-update-notification-email-addresses
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
b09acd1
#984: setNotifEmailAddr command added
yuliialikhyt 000778e
#984: added a function to update notifications for Automations
yuliialikhyt 76dda3e
#984: move updateNotifications under runMethod
yuliialikhyt 49440b9
#984: enable updating notes or email addresses, additional checks, mo…
yuliialikhyt 10a3fe3
#984: added 2 test cases for updateNotifications
yuliialikhyt 19f1318
#984: updated function name
yuliialikhyt 24543f0
#984: updateNotifications improvements
yuliialikhyt 581a3a1
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
yuliialikhyt 0f1c3fe
#984: fixed tests, adjusted logic to set some notifications, check if…
yuliialikhyt 48e37e1
#984: fixed tests - +2 api requests because there is a new test autom…
yuliialikhyt e7c93c2
#984: moved repetitive code into #getEncodedAutomationIDs()
yuliialikhyt 92dfd6e
#984: added interactive questions, no email validation at this point
yuliialikhyt 9934cbd
#984: corrected test
yuliialikhyt 83f679d
#984: remove notifications option
yuliialikhyt ae4cc5d
#984: added email validator
yuliialikhyt 309de98
#984: added a test for importFile
yuliialikhyt 94d8c11
#984: added a test for --clear option
yuliialikhyt 18cd195
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
yuliialikhyt ceefc04
#984: +1 test automations, the rest of the tests were adapted
yuliialikhyt 127e1e4
#984: --clear option for importFile
yuliialikhyt d87161a
#984: exit updateNotifications for importFile if user provided option…
yuliialikhyt 00704bf
#984: note was not set if email address was not provided
yuliialikhyt 3910110
#984: retrive for clearNotifications is already covered
yuliialikhyt e8f7744
#984: some improvements and more tests
yuliialikhyt 556d256
#984: ternary -> if
yuliialikhyt 1d30d9e
#984: removed error variable
yuliialikhyt 051b215
Update test/type.importFile.test.js
yuliialikhyt 9f822f6
Update test/type.automation.test.js
yuliialikhyt 720231c
#984: test update completion email address and error email address
yuliialikhyt 739eaf8
#984: +9 positive test cases
yuliialikhyt 10bf762
Merge branch 'feature/984-feature-bulk-update-notification-email-addr…
yuliialikhyt a38f02b
#984: +1 negative test case
yuliialikhyt 6d87df6
#984: group:
yuliialikhyt eff4b1a
#984: moved properties out of static variables
yuliialikhyt 55a3389
#984: removed static variables
yuliialikhyt d07cf91
Update lib/cli.js
yuliialikhyt 47c847d
#984: made getKeysToSetNotifications in MetadataType abstract, moved …
yuliialikhyt e07fba6
Merge branch 'feature/984-feature-bulk-update-notification-email-addr…
yuliialikhyt 5bdfa31
#984: clearNotifications was removed from MetadataType and index
yuliialikhyt 4cc50b3
#984: info to verbose
yuliialikhyt 592d3fb
#984: renamed negative test cases
yuliialikhyt 989fed4
#984: renamed negative test cases
yuliialikhyt 695afb0
#984: renamed test cases
yuliialikhyt fc03b1d
#984: split a test case into 2
yuliialikhyt 729eb96
#984: split a test case into 3
yuliialikhyt f691e6c
#984: +3 tests for clearNotifications (+3 cached automations, +6 API …
yuliialikhyt 3023492
#984: improved regex email validation
yuliialikhyt 9abe1e5
#984: moved type specific stuff into child class
yuliialikhyt 1609171
#984: removed options from updateNotifications command
yuliialikhyt 9bb5be7
#984: added a test for updating a note only
yuliialikhyt 0dc51ae
#984: +1 automation
yuliialikhyt 23d0cea
#984: added a function to retrieve and deploy that is used for fixKey…
yuliialikhyt 12f7b3d
#984: regex for email validation replaced
yuliialikhyt fe22dca
#984: add questions to an array
yuliialikhyt 0b43078
#984: validate added
yuliialikhyt 6c09a25
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
yuliialikhyt 9ddbefe
#984: test cases
yuliialikhyt f1ff0de
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
yuliialikhyt c18e6ef
#984: +15 automations/+15 API calls
yuliialikhyt 7b0de99
#984: fixed issue with email validation
yuliialikhyt 1101102
#984: merge develop into branch
yuliialikhyt 7fb1fb4
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
JoernBerkefeld af22fb9
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
JoernBerkefeld bd755f4
#0: auto-formatting
JoernBerkefeld 258c067
#984: improve log message for updateNotification
JoernBerkefeld 63f9784
#984: move updateNotification logic from custom createOrUpdate into p…
JoernBerkefeld 8e2670a
#984: rename importFile test for updateNotification
JoernBerkefeld 9981086
#984: refactoring
JoernBerkefeld 801317d
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
JoernBerkefeld f1df201
#0: pre-commit hook logs
JoernBerkefeld 6626df6
#984: fix tests for importFile & query
JoernBerkefeld 427764a
Merge remote-tracking branch 'origin/develop' into feature/984-featur…
JoernBerkefeld b056439
#984: clean up tests
JoernBerkefeld 7fe7db2
#984: clean up code
JoernBerkefeld 80b880e
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
JoernBerkefeld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.