-
Notifications
You must be signed in to change notification settings - Fork 6
fix(snyk): Update action and split report upload #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| --- | ||
| id: TASK-11 | ||
| title: Fix snyk workflow | ||
| status: Done | ||
| assignee: | ||
| - claude | ||
| - piotrzajac | ||
| created_date: '2026-04-12' | ||
| updated_date: '2026-04-12' | ||
| labels: [ci-cd, sec] | ||
| dependencies: [] | ||
| priority: medium | ||
| --- | ||
|
|
||
| ## Description | ||
|
|
||
| <!-- SECTION:DESCRIPTION:BEGIN --> | ||
| Two issues need fixing in `.github/workflows/snyk.yml`: | ||
|
|
||
| ### Issue 1 — Deprecated action | ||
|
|
||
| All three scan/monitor steps use `snyk/actions/dotnet@master`, which is officially | ||
| deprecated and no longer supported by Snyk (no .NET-specific replacement exists). | ||
|
|
||
| The recommended migration is `snyk/actions/setup@master` (installs the Snyk CLI only) | ||
| combined with explicit `run: snyk ...` commands. Since the workflow already runs on | ||
| `ubuntu-latest`, the Docker-based `setup` action works without any runner change. | ||
|
|
||
| ### Issue 2 — Multiple SARIF runs under the same category | ||
|
|
||
| The single `upload-sarif` step points to the `snyk/` directory, which contains two | ||
| SARIF files (`opensource.sarif` and `code.sarif`). GitHub Code Scanning no longer | ||
| allows multiple SARIF runs uploaded under the same category (announced 2025-07-21), | ||
| causing the workflow to fail with: | ||
|
|
||
| > The CodeQL Action does not support uploading multiple SARIF runs with the same | ||
| > category. Please update your workflow to upload a single run per category. | ||
|
|
||
| **Fix:** replace the single directory upload with two steps, each pointing to a | ||
| specific file with a distinct `category`. The `category` parameter creates an | ||
| independent slot in the GitHub Advanced Security dashboard — uploads coexist and | ||
| neither overwrites the other. | ||
| <!-- SECTION:DESCRIPTION:END --> | ||
|
|
||
| ## Acceptance Criteria | ||
|
|
||
| - [x] #1 All three `snyk/actions/dotnet@master` steps are replaced with `snyk/actions/setup@master` + `run:` commands | ||
| - [x] #2 The single `upload-sarif` directory step is replaced by two file-specific steps | ||
| - [x] #3 Each upload step specifies a distinct `category` (`snyk-opensource` and `snyk-code`) | ||
| - [x] #4 Both upload steps retain `if: ${{ always() }}` so results upload even when scans report findings | ||
| - [x] #5 The workflow runs without error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.